Skip to content

Commit

Permalink
fix: ssr regen (#1369)
Browse files Browse the repository at this point in the history
<!--- Please provide a general summary of your changes in the title
above -->

# Pull Request type

<!-- Please try to limit your pull request to one type; submit multiple
pull requests if needed. -->

Please check the type of change your PR introduces:

- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, renaming)
- [ ] Refactoring (no functional changes, no API changes)
- [ ] Build-related changes
- [ ] Documentation content changes
- [ ] Other (please describe):

## What is the current behavior?

<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Issue Number: N/A

## What is the new behavior?

<!-- Please describe the behavior or changes that are being added by
this PR. -->

-
-
-

## Does this introduce a breaking change?

- [ ] Yes
- [ ] No

<!-- If this does introduce a breaking change, please describe the
impact and migration path for existing applications below. -->

## Other information

<!-- Any other information that is important to this PR, such as
screenshots of how the component looks before and after the change. -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced the 404 page to always show the most current content by
revalidating with each request.
- Improved user experience on organization pages by ensuring fully
rendered content is delivered without intermediate loading states.

- **Bug Fixes**
- Resolved loading state issues by changing fallback behavior to block
until new pages are fully generated, improving content delivery
consistency.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • Loading branch information
JoeKarow authored Aug 6, 2024
1 parent dd13b3f commit 94b8b59
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion apps/app/src/pages/404.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export const getStaticProps: GetStaticProps = async ({ locale }) => {
props: {
...(await getServerSideTranslations(locale, ['common'])),
},
revalidate: 60 * 60 * 24 * 7,
revalidate: true,
}
}

Expand Down
2 changes: 1 addition & 1 deletion apps/app/src/pages/org/[slug]/[orgLocationId]/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ const OrgLocationPage: NextPage = () => {
export const getStaticPaths: GetStaticPaths = async () => {
return {
paths: [],
fallback: true,
fallback: 'blocking',
}
}
export const getStaticProps: GetStaticProps<
Expand Down
2 changes: 1 addition & 1 deletion apps/app/src/pages/org/[slug]/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ const OrganizationPage = ({
export const getStaticPaths: GetStaticPaths = async () => {
return {
paths: [],
fallback: true,
fallback: 'blocking',
}
}

Expand Down
2 changes: 1 addition & 1 deletion apps/app/src/pages/org/[slug]/remote.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ const RemoteServicesPage: NextPage = () => {
export const getStaticPaths: GetStaticPaths = async () => {
return {
paths: [],
fallback: true,
fallback: 'blocking',
}
}
export const getStaticProps: GetStaticProps<
Expand Down

0 comments on commit 94b8b59

Please sign in to comment.