fix(ui-tars): resolve page down and page up event error

web-infra-dev · Feb 10, 2025 · 38d55fb · 38d55fb
1 parent a5f92b8
commit 38d55fb
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/packages/shared/src/us-keyboard-layout.ts b/packages/shared/src/us-keyboard-layout.ts
@@ -712,15 +712,12 @@ const keyMap: Record<string, KeyInput> = {
 };
 
 export function transformHotkeyInput(keyInput: string): string[] {
+  // page down
+  if (keyMap[keyInput.toLowerCase()]) {
+    return [getKeyDefinition(keyMap[keyInput.toLowerCase()])];
+  }
+
   return keyInput.split(' ').map((key) => {
-    let newKey = key;
-    if (keyMap[key.toLowerCase()]) {
-      newKey = keyMap[key.toLowerCase()];
-    }
-    const keyDefinition = getKeyDefinition(newKey);
-    if (keyDefinition) {
-      return keyDefinition;
-    }
-    return newKey;
+    return getKeyDefinition(keyMap[key.toLowerCase()] || key);
   });
 }
diff --git a/packages/shared/tests/unit-test/keyboard.test.ts b/packages/shared/tests/unit-test/keyboard.test.ts
@@ -59,4 +59,9 @@ describe('transformHotkeyInput', () => {
   it('should handle empty input', () => {
     expect(transformHotkeyInput('')).toEqual(['']);
   });
+
+  it('should handle page down', () => {
+    expect(transformHotkeyInput('page down')).toEqual(['PageDown']);
+    expect(transformHotkeyInput('page up')).toEqual(['PageUp']);
+  });
 });