-
-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rspack_loader_swc): enable SWC plugins #5808
Conversation
You may use this as a base or maybe I will add some test cases later Also I had some runtime problems running pre-commit linters and didn't bother but will look into it |
Would you please add a case? ;-) |
I have added a test case |
I didn't notice stats snapshot failing locally because my $HOME has
Removed old test, and updated snapshots On my machine As for timeout of my test I don't know, will rerun fix it? |
I guess I'll have to spin up a Linux VM or something, because on M1 it passes without any timeouts 😅 To check that it doesn't actually hang And for CSS - is it just flaky, or did I actually break something? |
Yes, css test seems flaky and not being fixed. No worries. We will help you out! Would you please take a look at your earliest convenience? @JSerFeng |
Issue with the test looks similar to this swc-project/plugins#32 (comment) |
the error I guess the fix could be changing the
|
Also curious how large the @rspack/core package size increases to |
I'm able to reproduce this error on different CSS test cases (with |
If you have any trouble fixing that, feel free to tell us |
I see that But I can't reproduce build hanging on mac/linux. Can I try to increase timeout for
|
Seems like it helped Would you approve please? |
!canary |
0.5.5-canary-9e431a9-20240305043500 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Summary
Fixes #5763
I've locked
rkyv
to version which is used in swc and wrapped tuple in a struct as it wouldn't deserialize with an olderrkyv
versionRequire Documentation?