Fetch: test nosniff parsing better #13559
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| promise_test(() => fetch("resources/x-content-type-options.json").then(res => res.json()).then(runTests), "Loading JSON…"); | ||
|
|
||
| function runTests(allTestData) { | ||
| for (let i = 0; i < allTestData.length; i++) { | ||
| const testData = allTestData[i], | ||
| input = encodeURIComponent(testData.input); | ||
| async_test(t => { | ||
| const script = document.createElement("script"); | ||
| t.add_cleanup(() => script.remove()); | ||
| // A <script> element loading a classic script does not care about the MIME type, unless | ||
| // X-Content-Type-Options: nosniff is specified, in which case a JavaScript MIME type is | ||
| // enforced, which x/x is not. | ||
| if (testData.nosniff) { | ||
| script.onerror = t.step_func_done(); | ||
| script.onload = t.unreached_func("Script should not have loaded"); | ||
| } else { | ||
| script.onerror = t.unreached_func("Script should have loaded"); | ||
| script.onload = t.step_func_done(); | ||
| } | ||
| script.src = "resources/nosniff.py?nosniff=" + input; | ||
| document.body.appendChild(script); | ||
| }, input); | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| def main(request, response): | ||
| response.add_required_headers = False | ||
| output = "HTTP/1.1 220 YOU HAVE NO POWER HERE\r\n" | ||
| output += "Content-Length: 22\r\n" | ||
| output += "Content-Type: x/x\r\n" | ||
| output += request.GET.first("nosniff") + "\r\n" | ||
| output += "\r\n" | ||
| output += "// nothing to see here" | ||
| response.writer.write(output) | ||
| response.close_connection = True |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| [ | ||
| { | ||
| "input": "X-Content-Type-Options: NOSNIFF", | ||
| "nosniff": true | ||
| }, | ||
| { | ||
| "input": "x-content-type-OPTIONS: nosniff", | ||
| "nosniff": true | ||
| }, | ||
| { | ||
| "input": "X-Content-Type-Options: nosniff,,@#$#%%&^&^*()()11!", | ||
| "nosniff": true | ||
| }, | ||
| { | ||
| "input": "X-Content-Type-Options: @#$#%%&^&^*()()11!,nosniff", | ||
| "nosniff": false | ||
| }, | ||
| { | ||
| "input": "X-Content-Type-Options: nosniff\r\nX-Content-Type-Options: no", | ||
|
There was a problem hiding this comment. nit: Should probably use consistent indentation for all of these (x3) |
||
| "nosniff": true | ||
| }, | ||
| { | ||
| "input": "X-Content-Type-Options: no\r\nX-Content-Type-Options: nosniff", | ||
| "nosniff": false | ||
| }, | ||
| { | ||
| "input": "X-Content-Type-Options:\r\nX-Content-Type-Options: nosniff", | ||
| "nosniff": false | ||
| }, | ||
| { | ||
| "input": "X-Content-Type-Options: ,nosniff", | ||
| "nosniff": false | ||
| }, | ||
| { | ||
| "input": "X-Content-Type-Options: nosniff\u000C", | ||
| "nosniff": false | ||
| }, | ||
| { | ||
| "input": "X-Content-Type-Options: nosniff\u000B", | ||
| "nosniff": false | ||
| }, | ||
| { | ||
| "input": "X-Content-Type-Options: nosniff\u000B,nosniff", | ||
| "nosniff": false | ||
| }, | ||
| { | ||
| "input": "X-Content-Type-Options: 'NosniFF'", | ||
| "nosniff": false | ||
| }, | ||
| { | ||
| "input": "X-Content-Type-Options: \"nosniFF\"", | ||
| "nosniff": false | ||
| }, | ||
| { | ||
| "input": "Content-Type-Options: nosniff", | ||
| "nosniff": false | ||
| } | ||
| ] | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I live completely in network land, so am far from knowledgeable about Javascript or the web platform, beyond HTTP (Admittedly, in Chrome, that also includes the MIME sniffing logic), but looking at the updated test, I still find it non-obvious why the nosniff results in errors. The sniffed as text -> treated as valid Javascipt connection isn't obvious to me.
That having been said, I do think that this makes it much clearer that the onerror cases correspond to nosniff being respected.
Maybe just something along the lines of "The resource must be sniffed as test to be successfully loaded as a script."