webrtc: add third party sdp module #21933
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds a third-party module for SDP parsing, mangling and generation to the webrtc directory. This is going to be used for simulcast tests. Checks in node_modules as well as a package.json and yarn lock files for ease of updating. See web-platform-tests/rfcs#46 for discussіon on the approach
wpt-pr-bot
requested review from
agouaillard,
alvestrand,
guidou,
henbos,
jan-ivar,
rwaldron,
snuggs and
youennf
|
DO NOT MERGE pending discussion in web-platform-tests/rfcs#46 |
snuggs
reviewed
Feb 25, 2020
There was a problem hiding this comment.
@fippo pardon my ignorance but can we merely use sdp.js?
Please see my comments
P.S. SDP lib rocks!
|
We've decided to punt on how to manage npm packages systematically. For now, let's follow this comment:
|
|
closing this PR then. New one incoming ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a third-party module for SDP parsing, mangling and generation to the
webrtc directory. This is going to be used for simulcast tests.
Checks in node_modules as well as a package.json and yarn lock files for
ease of updating. See
web-platform-tests/rfcs#46
for discussіon on the approach