-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement testdriver features (RFC-214) #49122
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3a1f47a
to
a10955b
Compare
58d1051
to
4212ce0
Compare
testdriver_features
testdriver_features
testdriver_features
testdriver_features
c97ce07
to
bdf6e5f
Compare
f9b4b30
to
7eb8d6d
Compare
7eb8d6d
to
fea994b
Compare
testdriver_features
testdriver_features
OrKoN
approved these changes
Dec 6, 2024
225ded7
to
47b2147
Compare
0ed5c36
to
c329775
Compare
OrKoN
approved these changes
Dec 18, 2024
This comment was marked as duplicate.
This comment was marked as duplicate.
past
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few nits, but this looks good to me, thanks!
# Conflicts: # lint.ignore # tools/manifest/item.py
This was referenced Dec 19, 2024
c329775
to
5d34df3
Compare
sadym-chromium
added a commit
that referenced
this pull request
Jan 14, 2025
* Add support for testdriver features # Conflicts: # lint.ignore # tools/manifest/item.py * Enable BiDi for Chrome * lint rules * lint rules * indents * Update simulate_adapter.https.html.ini * check path correctly * Address PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add testdriver features and use in chrome. Implementation of RFC 214: Add testdriver features.
feature=bidi
infrastructure/webdriver/bidi/subscription.html
for chromeinfrastructure/testdriver/bidi/permissions/set_permission.https.html
for chromeinfrastructure/metadata/infrastructure/testdriver/bidi/bluetooth/simulate_adapter.https.html
for chrome