[wptrunner] Add a wpewebkit_minibrowser product/browser. #49268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
added
docs
infra
wpt
wptrunner
clopez
force-pushed
the
add_wpewebkit_minibrowser_runner
branch
4 times, most recently
from
e000f9f to
061124a
Compare
Ms2ger
requested changes
Nov 26, 2024
clopez
force-pushed
the
add_wpewebkit_minibrowser_runner
branch
4 times, most recently
from
4cbe0a4 to
885e80d
Compare
This adds a new browser type to run tests with the WPE WebKit port. It can be passed an optional `--headless` parameter to enable headless testing with WPT. Otherwise wayland is required. A pre-built nightly bundle can be also automatically downloaded and installed by passing `--install-browser` to the WPT runner. It shares with webkitgtk_minibrowser most of the logic to download and install the built product. Documentation is also added and the webkitgtk_minibrowser one updated accordingly. Unit tests are also added.
clopez
force-pushed
the
add_wpewebkit_minibrowser_runner
branch
from
885e80d to
9660171
Compare
|
@Ms2ger I think I addressed all your comments in this last version uploaded and unit tests are passing fine. Please, let me known your thoughts, thanks 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new browser type to run tests with the WPE WebKit port. It can be passed an optional
--headlessparameter to enable headless testing with WPT. Otherwise wayland is required.A pre-built nightly bundle can be also automatically downloaded and installed by passing
--install-browserto the WPT runner. It shares with webkitgtk_minibrowser most of the logic to download and install the built product.Documentation is also added and the webkitgtk_minibrowser one updated accordingly.
Unit tests are added and updated.