Replace place-items with align-items for customizable select #49964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Option elements in customizable select have place-items:center in order to vertically center the text of options. Since place-items is a shorthand for align-items and justify-items, we are unintentionally horizontally centering text in some cases. This patch replaces it with just align-items which effectively unsets the justify-items property. Change-Id: I540316dd4ff3512b5e48b7efac9f4794890693e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6153916 Commit-Queue: Joey Arhar <[email protected]> Reviewed-by: Traian Captan <[email protected]> Cr-Commit-Position: refs/heads/main@{#1403635}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6153916
branch
from
e626d2f to
1adcb23
Compare
wpt-pr-bot
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option elements in customizable select have place-items:center in order
to vertically center the text of options. Since place-items is a
shorthand for align-items and justify-items, we are unintentionally
horizontally centering text in some cases. This patch replaces it with
just align-items which effectively unsets the justify-items property.
Change-Id: I540316dd4ff3512b5e48b7efac9f4794890693e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6153916
Commit-Queue: Joey Arhar <[email protected]>
Reviewed-by: Traian Captan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1403635}