Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support window management #888

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

mato533
Copy link
Contributor

@mato533 mato533 commented Dec 30, 2024

Description

To support window management that supports switching between windows.
The WebdriverIO is not support auto switch between windows example of splash screen.

This PR is add the following features.

  • The service watches handle of the window. When it was changed, get new handle and call browser.switchToWindow(handle).
  • add Unit tests for below feature.
  • add E2E scenarios
    • no-binaly
    • forge
    • builder

Related issue

#771

@mato533 mato533 force-pushed the feature/window-mgmt branch from e44ffdc to dd74e4d Compare December 30, 2024 16:59
@mato533 mato533 marked this pull request as ready for review January 1, 2025 20:49
@mato533
Copy link
Contributor Author

mato533 commented Jan 1, 2025

I have converted to ready state from draft state of this pr.
And I would appreciate any feedback from experts you guys.

@goosewobbler
Copy link
Member

Wow, @mato533 this is great. I haven't had any time over the holidays to go over your other PR yet! I will look at them both tomorrow.

@christian-bromann What do you think to adding @mato533 to the community org as a contributor?

@christian-bromann
Copy link
Contributor

What do you think to adding @mato533 to the community org as a contributor?

Sure thing! Thanks for this awesome contribution @mato533 🙏

@mato533
Copy link
Contributor Author

mato533 commented Jan 6, 2025

@goosewobbler @christian-bromann
I'm very happy to be told that.
And thank you for the invitation! I'm looking forward to collaborate with you guys.

@mato533 mato533 linked an issue Jan 10, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Window Management E2Es
3 participants