refactor: apply webpack-defaults #55
Conversation
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
=========================================
Coverage ? 45.13%
=========================================
Files ? 4
Lines ? 144
Branches ? 44
=========================================
Hits ? 65
Misses ? 66
Partials ? 13
Continue to review full report at Codecov.
|
joshwiens
added
pr_action: Review
semver: Major
type: Refactor
and removed
DO NOT MERGE
labels
package.json
Outdated
| }, | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "[email protected]:sairion/svg-inline-loader.git" |
There was a problem hiding this comment.
sairion => webpack-contrib
package.json
Outdated
| "url": "[email protected]:sairion/svg-inline-loader.git" | ||
| }, | ||
| "bugs": { | ||
| "url": "https://github.com/sairion/svg-inline-loader/issues" |
There was a problem hiding this comment.
sairion => webpack-contrib
package.json
Outdated
| "bugs": { | ||
| "url": "https://github.com/sairion/svg-inline-loader/issues" | ||
| }, | ||
| "homepage": "https://github.com/sairion/svg-inline-loader", |
There was a problem hiding this comment.
sairion => webpack-contrib
| "node-libs-browser": "^1.0.0", | ||
| "nodemon": "^1.11.0", |
| "babel-preset-env": "^1.6.0", | ||
| "cross-env": "^5.0.1", | ||
| "del-cli": "^1.1.0", | ||
| "eslint": "^3.18.0", |
There was a problem hiding this comment.
Can be bumped to >= v4.x
| "prepublish": "npm run build", | ||
| "release": "standard-version", | ||
| "security": "nsp check", | ||
| "serve:dev": "nodemon $2 --exec babel-node", |
| @@ -0,0 +1,18 @@ | |||
| { | |||
| "extends": "webpack", | |||
| "rules": { | |||
There was a problem hiding this comment.
Intentional or left over ?
| } | ||
|
|
||
| function SVGInlineLoader(content) { | ||
| this.cacheable && this.cacheable(); // eslint-disable-line no-unused-expressions |
|
|
||
| function SVGInlineLoader(content) { | ||
| this.cacheable && this.cacheable(); // eslint-disable-line no-unused-expressions | ||
| this.value = content; |
|
This shouldn't have had the review label on it yet, sorry |
joshwiens
force-pushed
the
d3viant0ne-WebpackDefaults
branch
from
eee249c to
92b0dc7
Compare
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
=========================================
Coverage ? 45.13%
=========================================
Files ? 4
Lines ? 144
Branches ? 44
=========================================
Hits ? 65
Misses ? 66
Partials ? 13 Continue to review full report at Codecov.
|
Intended to be merged as a part of
1.0.0on a betadist-tagonce this has been finished and properly tested.Further refactoring and test fixes are required to align with the defaults.
BREAKING CHANGE:
Enforces NodeJS > 4.3 via engines
Closes #56