Skip to content
This repository has been archived by the owner on Aug 15, 2024. It is now read-only.

Update ferros/buffer to version 5 #67

Closed
wants to merge 1 commit into from

Conversation

venik
Copy link

@venik venik commented Aug 30, 2017

Hi,

is it possible to update ferros/buffer to version 5? Problem is that versions 4.X refers to global

Buffer.TYPED_ARRAY_SUPPORT = global.TYPED_ARRAY_SUPPORT !== undefined
  ? global.TYPED_ARRAY_SUPPORT
  : typedArraySupport()

which leads to #60 and #31

this patch has fixed this problem and version 5.X works just fine.

We used shrinkwrap to work it around, but would be better to have updated version of the node-libs-browser (npm-shrinkwrap.json):

{
  "dependencies": {
    "webpack": {
      "version": "3.3.0",
      "dependencies": {
        "node-libs-browser": {
          "version": "2.0.0",
          "dependencies": {
            "buffer": {
              "version": "5.0.7"
            }
          }
        }
      }
    }
  }
}

Thanks in advance!

@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Sasha Nikiforov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@venik venik closed this Aug 30, 2017
@venik venik deleted the bumpBufferTo5 branch August 30, 2017 04:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants