This repository has been archived by the owner on Aug 23, 2022. It is now read-only.
poll_data_channel: implement polling instead of proxying to stream #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since DataChannel has its own read & write implementations (which call Stream::read and Stream::write), we can't poll stream directly, but have to construct futures ourselves and poll them. Most of the code was copied from sctp::Stream.
Codecov Report
@@ Coverage Diff @@
## main #9 +/- ##
==========================================
- Coverage 14.98% 14.92% -0.07%
==========================================
Files 7 7
Lines 3310 3310
Branches 960 958 -2
==========================================
- Hits 496 494 -2
- Misses 2531 2533 +2
Partials 283 283
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since DataChannel has its own read & write implementations (which call
Stream::read and Stream::write), we can't poll stream directly, but have
to construct futures ourselves and poll them.
Most of the code was copied from sctp::Stream.