Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTCDataChannel not properly closed #468

Closed
Marcel-G opened this issue Jul 18, 2023 · 1 comment · Fixed by #480
Closed

RTCDataChannel not properly closed #468

Marcel-G opened this issue Jul 18, 2023 · 1 comment · Fixed by #480

Comments

@Marcel-G
Copy link
Contributor

Marcel-G commented Jul 18, 2023

Problem

When RTCDataChannel: close() method on a JS client (Chrome for example) the data channel hangs in closing state and never transitions to closed.
This causes a memory leak and eventually more data channels cannot be created with the following error:

Uncaught (in promise) DOMException: Failed to execute 'createDataChannel' on 'RTCPeerConnection': RTCDataChannel creation failed

Reproduction

Using the examples/data-channels
Run the JS test for closing data channels: jsfiddle
Note the RTCDataChannel never enters closed state.

Possible cause

I suspect the issue here is with webrtc-rs not replying with a stream reset to the browsers request to close the stream. I see the spec referenced here but am not sure if it's working correctly.

@Marcel-G
Copy link
Contributor Author

Possibly relevant info in pion/sctp#238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant