-
-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(data-channel): stuck closing in Chrome #480
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #480 +/- ##
==========================================
- Coverage 61.80% 61.79% -0.02%
==========================================
Files 530 530
Lines 48858 48860 +2
Branches 12324 12326 +2
==========================================
- Hits 30199 30194 -5
- Misses 9499 9502 +3
- Partials 9160 9164 +4
☔ View full report in Codecov by Sentry. |
@mxinden this remaining issues something you can help with? |
should we port the fix from webrtc-rs/sctp-proto#6 to here? |
8e9864c
to
c6660bf
Compare
@rainliu yes, works like a charm! |
c6660bf
to
78b0a0d
Compare
78b0a0d
to
c257866
Compare
Great. Could you please fix format/clippy warning? |
Still clippy errors.Make sure you are using same or above cargo version in the GitHub actions. |
38f5367
to
417ab7e
Compare
417ab7e
to
3b5f1fa
Compare
Resolves #468
Currently the library does not properly implement the shutdown procedure for data channels closed by Chrome. In order for the data channel to fully close, it must receive a
OutgoingResetRequest
.This was an existing issue in pion which has since been resolved here pion/sctp#238
Reproduction
Using the examples/data-channels
Run the JS test for closing data channels: jsfiddle
Note the RTCDataChannels never enter
closed
state.