Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable builds on every push, add macos arm builds #2350

Closed
wants to merge 3 commits into from

Conversation

Paxa
Copy link

@Paxa Paxa commented Jun 6, 2023

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix
[ ] New feature
[v] Other, please explain:

What changes did you make? (Give an overview)

  • enable macos builds for apple silicon
  • enable package builds on every push
  • add link to dev builds in readme

Which issue (if any) does this pull request address?

#2309 (comment)

Is there anything you'd like reviewers to focus on?

  1. What will be better to make separate x86 and arm builds or use universal type? (https://github.com/electron/universal)

Example of download page https://nightly.link/Paxa/webtorrent-desktop/workflows/package/dev-builds (zips are quite big because one job produce mulple files)
To make nightly.link it will require to authorize this app in github oauth

I've checked mac package, it contain .zip and .dmg files, will it be ok to keep only .dmg ?

Screenshot 2023-06-07 at 04 35 34

@welcome
Copy link

welcome bot commented Jun 6, 2023

🙌 Thanks for opening this pull request! You're awesome.

@socket-security
Copy link

New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives1 Size Publisher
electron-packager ⬆️ 15.5.2...17.1.1 None +8/-7 880 kB georgexu99

Footnotes

  1. https://docs.socket.dev

@dsernst
Copy link
Contributor

dsernst commented Jul 5, 2023

Love to see this. Does this PR produce a binary we can test?

@Paxa
Copy link
Author

Paxa commented Jul 5, 2023

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@github-actions github-actions bot added the stale label Sep 4, 2023
@github-actions github-actions bot closed this Sep 11, 2023
@dsernst
Copy link
Contributor

dsernst commented Nov 15, 2024

@dsernst It does, you can see in last pipeline Paxa/webtorrent-desktop/actions/runs/5193592670 (artifacts section below) or on here nightly.link/Paxa/webtorrent-desktop/workflows/package/dev-builds

Links appearing to be 404'ing currently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants