Skip to content
This repository has been archived by the owner on Jul 7, 2024. It is now read-only.

shear map in new 'analysis' folder #77

Merged
merged 3 commits into from
Sep 29, 2016
Merged

Conversation

davharris
Copy link
Contributor

@davharris davharris commented Sep 27, 2016

(also remove some dead folders I created last year). This replaces the shear maps in #45

@ethanwhite
Copy link
Member

Looks good. Thanks!

My one question is whether to keep this in it's own file (which I think should then probably be in ./R/ or put it inside forecast-bbs-core.R. My natural inclination is the latter, but I if that inclination to put lots of things in a single file is my Python background talking I'm certainly happy to do the more R-like thing.

@davharris
Copy link
Contributor Author

I think putting it somewhere in the R folder does make more sense. We'll
probably end up adding ggplot as a dependency eventually anyway. Good call

On Tue, Sep 27, 2016 at 4:49 PM, Ethan White [email protected]
wrote:

Looks good. Thanks!

My one question is whether to keep this in it's own file (which I think
should then probably be in ./R/ or put it inside forecast-bbs-core.R. My
natural inclination is the latter, but I if that inclination to put lots of
things in a single file is my Python background talking I'm certainly happy
to do the more R-like thing.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#77 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAzdCYEU0IBzz6L4jqhXtvS-j77EjMc-ks5quYE_gaJpZM4KHv0f
.

@davharris
Copy link
Contributor Author

This should be ready to merge, I think.

@ethanwhite ethanwhite merged commit 3b36c61 into weecology:master Sep 29, 2016
This was referenced Sep 30, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants