Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WELD-2769 Support the ELAwareBeanManager #182

Merged
merged 2 commits into from
Dec 11, 2023
Merged

WELD-2769 Support the ELAwareBeanManager #182

merged 2 commits into from
Dec 11, 2023

Conversation

arjantijms
Copy link
Contributor

No description provided.

@arjantijms arjantijms requested a review from manovotn as a code owner December 11, 2023 11:15
@manovotn
Copy link
Contributor

JIRA link - https://issues.redhat.com/browse/WELD-2769

@manovotn manovotn changed the title Support the ELAwareBeanManager WELD-2769 Support the ELAwareBeanManager Dec 11, 2023
manovotn
manovotn reviewed Dec 11, 2023
View reviewed changes
pom.xml
<groupId>jakarta.enterprise</groupId>
<artifactId>jakarta.enterprise.cdi-el-api</artifactId>
<version>${cdi.api.version}</version>
</dependency>
Copy link
Contributor

@manovotn manovotn Dec 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll also need to add an exclusion for EL API artifact here.
I'll check and add on to your PR if needed.

@manovotn manovotn force-pushed the support_ELAwareBeanManager branch from bfec2c8 to 81d809d Compare December 11, 2023 12:09
@manovotn manovotn merged commit 63c3611 into weld:master Dec 11, 2023
2 checks passed
@manovotn
Copy link
Contributor

Thanks @arjantijms!

@arjantijms
Copy link
Contributor Author

Thank you too!

Next step would be updating weld-api in weld core, and then having org.jboss.weld.util.ForwardingBeanManager implement ELAwareBeanManager as well?

@manovotn
Copy link
Contributor

Next step would be updating weld-api in weld core, and then having org.jboss.weld.util.ForwardingBeanManager implement ELAwareBeanManager as well?

Yes, we need Weld API release for that but I am waiting on how the method invokers PR turns out.
There is likely an API simplification coming in which case we'll be adding existing functionality via Weld API.
That said, I could just roll out several API releases too 🤷

@manovotn
Copy link
Contributor

I've gone ahead and released the API so that this doesn't get forgotten. Here's the PR upgrading the API and making ForwardingBM implement the new API - weld/core#2900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manovotn manovotn manovotn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arjantijms @manovotn