-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
erofs: Change the erofs compression default to zstd #1435
Conversation
--rootfs-type erofs now uses: zstd,8 -Ededupe,all-fragments -C 65536 unless overridden by the 'compression.erofs' section of a lorax config file.
68321cd
to
0571214
Compare
Pull Request Test Coverage Report for Build 11939805641Details
💛 - Coveralls |
What's the justification for |
It produces somewhat smaller images. They're still not really close to squashfs yet, but it is an improvement. |
hi @bcl and @Conan-Kudo, I've added a FAQ for this https://erofs.docs.kernel.org/en/latest/faq.html Anyway, you could also package all files into tar, and compress this tar with EROFS and Squashfs to confirm if the difference is from metadata compression then.
If you compares with Squashfs |
I'm trying out zstd,1 with the rest of those options right now: https://pagure.io/fedora-kiwi-descriptions/pull-request/105 |
Okay |
With |
that is a problem due to |
I guess I'm not sure if ~0.3GB is all due to metadata compression, but you could try to generate a tar for all files first, and then compress the tar with Or you could use |
I didn't have a way to turn off |
@Conan-Kudo Anyway that is the current status of the image sizes, if you have more time to confirm In short, I know there is still efforts to close the image size gap against squashfs. and I will try to prioritize some first, maybe multithreaded compressed deduplication support is more useful but it'd be better to confirm (even it's too slow..) |
I will do a run with this, I do expect it to take multiple hours though. |
I guess could you try to disable this by dropping Line 128 in 55701a1
? |
I'm not using lorax, I'm using kiwi, but yes I could do something similar. |
Please move kiwi discussions to a more appropriate place :) FWIW in my tests I can use Trying 128k block size saved 4MB, using -T only saved 1MB and using |
yes, |
That's odd, because it is very slow on my Framework 16, and it's also quite slow in Zuul CI. It's not specific to kiwi, as it's the actual mkfs.erofs run that is slow. |
Anyway, this run took 1 hour and 15 minutes, but the resulting image is 2.8GB. |
@Conan-Kudo ok, then I assume both dedupe and BCJ can help to get a smaller image then.. Also it seems kiwi uses |
Yeah, I think so. I'd like to get to the point where we can get compression parity and set similar defaults in kiwi like lorax is attempting to do now. |
--rootfs-type erofs now uses:
zstd,8 -Ededupe,all-fragments -C 65536
unless overridden by the 'compression.erofs' section of a lorax config file.