Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mho/pipes #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

mho/pipes #4

wants to merge 3 commits into from

Conversation

mhzawadi
Copy link

@mhzawadi mhzawadi commented Mar 19, 2021

bug: download pipes


This change is Reviewable

bug: download pipes
feat: add github actions
@wernight
Copy link
Owner

I'd remove the commit related to github workflow.

Copy link
Owner

@wernight wernight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can push to the Docker Hub repo but this pushes to yours. I'm not sure about the benefits compared to Docker Hub though.

@mhzawadi
Copy link
Author

sorry about that, have fixed the github actions now

@@ -53,8 +54,10 @@ RUN apt-get update \
&& chmod +x /usr/local/bin/falling-hearts \

&& echo "Install pipes" \
&& curl -L https://gist.githubusercontent.com/livibetter/4689307/raw/949e43fe2962c2c97c8b1d974ff93dd053d9bd37/pipes.sh -o /usr/local/bin/pipes \
&& chmod +x /usr/local/bin/pipes \
&& curl -L https://github.com/pipeseroni/pipes.sh/archive/v1.3.0.tar.gz -o pipes-v1.3.0.tar.gz \
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it'd be nicer to have the latest released set somewhere or even auto-fetched.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that might be an option, but as the last release was 2018 Im not sure this will need much work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants