Merge pull request #91 from wework/fix-conn

closing rows when querying transactional outbox fails
wework · Jun 23, 2019 · 8eb4f85 · 8eb4f85
2 parents 4adf30e + 58e1426
commit 8eb4f85
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/gbus/tx/mysql/txoutbox.go b/gbus/tx/mysql/txoutbox.go
@@ -241,7 +241,10 @@ func (outbox *TxOutbox) sendMessages(recordSelector func(tx *sql.Tx) (*sql.Rows,
 
 	if selectErr != nil {
 		outbox.log().WithError(selectErr).Error("failed fetching messages from outbox")
-
+		err := rows.Close()
+		if err != nil {
+			outbox.log().WithError(err).Error("could not close Rows")
+		}
 		return selectErr
 	}