Editorial: initialize clearTargets in event dispatch correctly #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also clean up "for each" wording while here. Fixes #1344.
domenic
approved these changes
Jan 15, 2025
| <li><p>If <var>clearTargetsStruct</var>'s <a for=Event/path>shadow-adjusted target</a>, | ||
| <var>clearTargetsStruct</var>'s <a for=Event/path>relatedTarget</a>, or an {{EventTarget}} object | ||
| in <var>clearTargetsStruct</var>'s <a for=Event/path>touch target list</a> is a <a for=/>node</a> | ||
| whose <a for=tree>root</a> is a <a for=/>shadow root</a>: set <var>clearTargets</var> to true. |
There was a problem hiding this comment.
Suggested change
| whose <a for=tree>root</a> is a <a for=/>shadow root</a>: set <var>clearTargets</var> to true. | |
| whose <a for=tree>root</a> is a <a for=/>shadow root</a>, then set <var>clearTargets</var> to true. |
There was a problem hiding this comment.
I did this deliberately as I thought using a colon here would make it clearer. In particular because the clause following "or" is rather long. WDYT?
There was a problem hiding this comment.
Yeah, either way seems OK, it's just a bit unusual and I thought ", then" was also distinctive enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also clean up "for each" wording while here.
Fixes #1344.
Preview | Diff