Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Change exceptions to be more precise - part 2 #88

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Editorial: Change exceptions to be more precise - part 2 #88

merged 1 commit into from
Jan 12, 2023

Conversation

a-sully
Copy link
Collaborator

@a-sully a-sully commented Jan 12, 2023 •
edited by pr-preview bot
Loading

Fixes #63

These should have been fixed in #70 but clearly I missed some ¯\(ツ)/¯

Preview | Diff

@a-sully
Use more precise exceptions... again
a91ecef 
Fixes whatwg#63

These should have been fixed in whatwg#70 but ¯\_(ツ)_/¯
@a-sully a-sully requested a review from annevk January 12, 2023 00:57
annevk
annevk approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Up to you if you also want to tackle the throw xref issue here.

@annevk
Copy link
Member

annevk commented Jan 12, 2023

By the way, when squashing and merging please pay attention to the details: https://github.com/whatwg/meta/blob/main/COMMITTING.md#squash-and-merge. Ideally the linear commit log of a specification is very readable and scannable.

@a-sully
Copy link
Collaborator Author

a-sully commented Jan 12, 2023

Great! Up to you if you also want to tackle the throw xref issue here.

I'll do this in a follow-up shortly

By the way, when squashing and merging please pay attention to the details: https://github.com/whatwg/meta/blob/main/COMMITTING.md#squash-and-merge. Ideally the linear commit log of a specification is very readable and scannable.

Ah, thank you for the pointer!

@a-sully a-sully merged commit c482c69 into whatwg:main Jan 12, 2023
@a-sully a-sully deleted the follow-up-on-70 branch January 12, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Be more precise about exceptions
2 participants
@a-sully @annevk