Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a storage task source #155

Merged
merged 5 commits into from
Jan 16, 2023
Merged

Conversation

a-sully
Copy link
Contributor

@a-sully a-sully commented Jan 10, 2023

See whatwg/fs#3

Writes using any storage API should be rejected if the site is out of quota. Therefore all writes from storage APIs which may affect or be affected by quota should run in order (at least per-site)

Fixes #89


Preview | Diff

@a-sully a-sully mentioned this pull request Jan 10, 2023
@annevk annevk requested a review from domenic January 13, 2023 12:41
@annevk
Copy link
Member

annevk commented Jan 13, 2023

Proposed commit message:

Introduce a storage task source and queue a storage task

Also make use of them internally. Additionally cross-reference more and adopt modern practices.

Helps with whatwg/fs#3. Fixes #89.

@annevk
Copy link
Member

annevk commented Jan 13, 2023

@a-sully if this looks good to you and @domenic I'll merge it Monday. @domenic this is mainly a heads as you introduced "queue a global task".

@a-sully
Copy link
Contributor Author

a-sully commented Jan 13, 2023

LGTM! Thanks for cleaning this up

@@ -14,6 +14,10 @@ urlPrefix: https://tc39.github.io/ecma262/; spec: ECMASCRIPT
text: agent cluster; url: #sec-agent-clusters; type: dfn
</pre>

<pre class=link-defaults>
spec:infra; type:dfn; text:implementation-defined
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might not be necessary after some changes made late in the day on Friday.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to still be necessary unfortunately.

@annevk annevk merged commit 1180744 into whatwg:main Jan 16, 2023
@a-sully a-sully deleted the storage-task-source branch January 17, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Define task source
3 participants