Add the frozen_string_literal header #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think after Ruby 3.4 is released, more people will start expecting libraries to be functional with eg the `--enable-frozen-string-literal` option enabled. This commit adds the frozen_string_literal header to all files, fixes failing tests, and removes now unnecessary freezing of strings.
bquorning
force-pushed
the
test-with-frozen-strings-flag
branch
from
725f910 to
7e5e57e
Compare
|
Doesn't this regress the functionality on pre-3.4 by removing the freezes? |
|
With the added |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think after Ruby 3.4 is released1, more people will start expecting libraries to be functional with e.g. the
--enable-frozen-string-literaloption enabled.This PR adds the
frozen_string_literalheader to all files, fixes failing tests, and removes now unnecessary freezing of strings.Footnotes
https://github.com/ruby/ruby/commit/12be40ae6be78ac41e8e3f3c313cc6f63e7fa6c4 ↩