Add support for running tests against different DB adapters #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-darbinyan
force-pushed
the
issue-113-support-multiple-db-adapters-for-tests
branch
3 times, most recently
from
364df12 to
adcaa00
Compare
ka8725
reviewed
Jan 7, 2025
| assert_response :redirect | ||
| get :index | ||
| message = "An error has occurred, this and all later migrations canceled:\n\nActiveRecord::IrreversibleMigration" | ||
| message = if ENV["DB_ADAPTER"] == "mysql2" | ||
| "An error has occurred, all later migrations canceled:\n\nActiveRecord::IrreversibleMigration" |
There was a problem hiding this comment.
Suggested change
| "An error has occurred, all later migrations canceled:\n\nActiveRecord::IrreversibleMigration" | |
| "An error has occurred, all subsequent migrations have been canceled:\n\nActiveRecord::IrreversibleMigration" |
There was a problem hiding this comment.
The error message is generated by Rails and is specific to the database adapter. For MySQL the message is An error has occurred, all subsequent migrations have been canceled, while for other adapters (PostgreSQL, SQLite) it's An error has occurred, this and all later migrations canceled. Making the suggested change would cause the test to fail for the MySQL adapter.
| message = if ENV["DB_ADAPTER"] == "mysql2" | ||
| "An error has occurred, all later migrations canceled:\n\nActiveRecord::IrreversibleMigration" | ||
| else | ||
| "An error has occurred, this and all later migrations canceled:\n\n" \ |
There was a problem hiding this comment.
Suggested change
| "An error has occurred, this and all later migrations canceled:\n\n" \ | |
| "An error has occurred; this migration and all subsequent ones have been canceled:\n\n" \ |
m-darbinyan
force-pushed
the
issue-113-support-multiple-db-adapters-for-tests
branch
from
adcaa00 to
9e64161
Compare
ka8725
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #113
Description
This PR adds new rake tasks to support running tests with different database adapters:
rake test:sqlite3: Runs tests using SQLite3 (default, equivalent torake test).rake test:postgresql: Runs tests using PostgreSQL (requires Docker).rake test:mysql2: Runs tests using MySQL (requires Docker).rake test:all: Runs tests across all supported adapters (SQLite3, PostgreSQL, and MySQL). Docker is used for PostgreSQL and MySQL.