Wildfly mini serie client service #4

tommaso-borgato · 2024-10-17T12:17:20Z

Source code for guides in wildfly/wildfly.org#671

tommaso-borgato · 2024-11-07T10:31:36Z

@bstansberry can you assign a reviewer?

jamezp

Just a few comments as it looks like they were copy/pasted to each example. Once we agree and the changes have been propagated to the other examples, I'll have a look again.

jamezp · 2024-11-12T23:28:34Z

...ces-on-kubernetes/simple-microservice-rest-client/simple-microservice-client-secured/pom.xml

+        <repository>
+            <id>central</id>
+            <name>Main Apache Maven Repository</name>
+            <url>https://repo.maven.apache.org/maven2/</url>
+            <layout>default</layout>
+            <releases>
+                <enabled>true</enabled>
+                <updatePolicy>never</updatePolicy>
+            </releases>
+            <snapshots>
+                <enabled>false</enabled>
+                <updatePolicy>never</updatePolicy>
+            </snapshots>
+        </repository>


There is no need to add this one.

jamezp · 2024-11-12T23:28:48Z

...ces-on-kubernetes/simple-microservice-rest-client/simple-microservice-client-secured/pom.xml

+        <pluginRepository>
+            <id>central</id>
+            <name>Main Apache Maven Repository</name>
+            <url>https://repo.maven.apache.org/maven2/</url>
+            <releases>
+                <enabled>true</enabled>
+                <updatePolicy>never</updatePolicy>
+            </releases>
+            <snapshots>
+                <enabled>false</enabled>
+                <updatePolicy>never</updatePolicy>
+            </snapshots>
+        </pluginRepository>


There is no need to add this one.

jamezp · 2024-11-13T02:27:28Z

...ces-on-kubernetes/simple-microservice-rest-client/simple-microservice-client-secured/pom.xml

+
+    <packaging>war</packaging>
+    <name>simple-microservice-client-secured</name>
+    <description>Insert description for your project here.</description>


Seems like we should just delete the description.

jamezp · 2024-11-13T02:27:41Z

...ces-on-kubernetes/simple-microservice-rest-client/simple-microservice-client-secured/pom.xml

+
+        <!-- JBoss dependency versions -->
+        <version.wildfly.maven.plugin>5.0.0.Final</version.wildfly.maven.plugin>
+        <version.wildfly.bom>33.0.2.Final</version.wildfly.bom>


We should use 34.0.0.Final

jamezp · 2024-11-13T02:28:18Z

...ces-on-kubernetes/simple-microservice-rest-client/simple-microservice-client-secured/pom.xml

+        <version.wildfly.bom>33.0.2.Final</version.wildfly.bom>
+
+        <!--Use JUnit 5 here - the WildFly bom still brings 4.x -->
+        <version.junit5>5.10.1</version.junit5>


5.11.3 is the latest.

jamezp · 2024-11-13T02:28:52Z

...ces-on-kubernetes/simple-microservice-rest-client/simple-microservice-client-secured/pom.xml

+
+            <dependency>
+                <groupId>org.wildfly.bom</groupId>
+                <artifactId>wildfly-microprofile</artifactId>


This should be wildfly-expansion for version 34.0.0.Final+

Thank you @jamezp ... I missed that

jamezp · 2024-11-13T02:30:11Z

...rvice-client-secured/src/main/java/org/wildfly/examples/GettingStartedEndpointInterface.java

This is missing the copyright.

jamezp · 2024-11-13T02:30:39Z

...rvice-client-secured/src/main/java/org/wildfly/examples/GettingStartedEndpointInterface.java

+@RegisterClientHeaders
+@RegisterRestClient(configKey="simple-microservice-server")
+@Path("/hello")
+public interface GettingStartedEndpointInterface {


IMO we should just name this GettingStartedEndpointClient.

tommaso-borgato · 2024-11-29T09:05:27Z

@jamezp Thank you for your review!

tommaso-borgato · 2024-11-29T09:09:16Z

@jamezp Thank you again for your review, I hope I have fixed everything you pointed out

tommaso-borgato · 2024-12-23T17:11:28Z

@jamezp Thank you again fro your review, do you think this is ready to be merged now?

jamezp · 2024-12-23T17:12:57Z

@jamezp Thank you again fro your review, do you think this is ready to be merged now?

@tommaso-borgato Sorry, I didn't get a chance to review it before PTO. I might not have a chance until I get back on the 2nd of January.

tommaso-borgato · 2025-01-16T09:37:22Z

@jamezp Do you think this is ready to be merged now (together with wildfly/wildfly.org#671)?

jamezp

Overall this looks okay. I've made some comments primarily around component upgrades. This is something we're going to need to figure out how to manage as it could get rather daunting to check for upgrades on each release. This is not something that needs to be resolved in this PR.

One question I have is why are we using Dockerfile's instead of having the wildfly-mavne-plugin create and deploy the images? It feels like an extra step that could simply be part of the build and ensure the correct Dockerfile content is created not having to worry about updating them in the future if something changes.

In general with these guide examples, we need to be able to easily keep them up to date without a lot of overhead.

jamezp · 2025-01-16T21:16:25Z

get-started-microservices-on-kubernetes/simple-microservice-database/pom.xml

+        <version.wildfly.maven.plugin>5.0.1.Final</version.wildfly.maven.plugin>
+        <version.wildfly.bom>34.0.1.Final</version.wildfly.bom>


These should probably be upgraded.

jamezp · 2025-01-16T21:16:48Z

get-started-microservices-on-kubernetes/simple-microservice-infinispan/pom.xml

+        <version.wildfly.maven.plugin>5.0.1.Final</version.wildfly.maven.plugin>
+        <version.wildfly.bom>34.0.1.Final</version.wildfly.bom>


Same note here about the upgrades.

jamezp · 2025-01-16T21:17:01Z

get-started-microservices-on-kubernetes/simple-microservice-jms/pom.xml

+        <version.wildfly.maven.plugin>5.0.1.Final</version.wildfly.maven.plugin>
+        <version.wildfly.bom>34.0.1.Final</version.wildfly.bom>


jamezp · 2025-01-16T21:17:54Z

...ces-on-kubernetes/simple-microservice-rest-client/simple-microservice-client-secured/pom.xml

+        <version.war.plugin>3.4.0</version.war.plugin>
+
+        <!-- maven-compiler-plugin -->
+        <maven.compiler.release>11</maven.compiler.release>


Should this be Java 17 now?

jamezp · 2025-01-16T21:18:09Z

...ces-on-kubernetes/simple-microservice-rest-client/simple-microservice-client-secured/pom.xml

+        <version.wildfly.maven.plugin>5.0.1.Final</version.wildfly.maven.plugin>
+        <version.wildfly.bom>34.0.1.Final</version.wildfly.bom>


These should probably be upgraded.

jamezp · 2025-01-16T21:19:47Z

...e-microservice-client-secured/src/main/java/org/wildfly/examples/GettingStartedEndpoint.java

+        OidcSecurityContext oidcSecurityContext = getOidcSecurityContext(httpServletRequest);
+        if (oidcSecurityContext != null) {
+            String authzHeaderValue = "Bearer " + oidcSecurityContext.getTokenString();
+            System.out.println("\n\n[JWT] service Token: " + authzHeaderValue + "\n\n");


We should use logging here instead of System.out.

jamezp · 2025-01-16T21:20:02Z

...e-microservice-server-secured/src/main/java/org/wildfly/examples/GettingStartedEndpoint.java

+	@Produces(MediaType.TEXT_PLAIN)
+	@RolesAllowed({"admin"})
+	public Response sayHello(final @PathParam("name") String name) {
+		System.out.println("mp.jwt.verify.publickey.location=" + publicKeyLocation);


We should use logging here instead of System.out.

jamezp · 2025-01-16T21:29:09Z

...croservices-on-kubernetes/simple-microservice-rest-client/simple-microservice-client/pom.xml

+        <version.wildfly.maven.plugin>5.0.1.Final</version.wildfly.maven.plugin>
+        <version.wildfly.bom>34.0.1.Final</version.wildfly.bom>


Same notes about upgrades.

jamezp · 2025-01-16T21:29:52Z

...croservices-on-kubernetes/simple-microservice-rest-client/simple-microservice-client/pom.xml

+            <dependency>
+                <groupId>org.junit</groupId>
+                <artifactId>junit-bom</artifactId>
+                <version>5.10.1</version>


Why aren't we using the property version here?

jamezp · 2025-01-16T21:30:06Z

...croservices-on-kubernetes/simple-microservice-rest-client/simple-microservice-server/pom.xml

+            <dependency>
+                <groupId>org.junit</groupId>
+                <artifactId>junit-bom</artifactId>
+                <version>5.10.1</version>


Why aren't we using the property here?

tommaso-borgato · 2025-01-20T14:51:26Z

@jamezp Thank you for your review!!! I used Dockerfile on purpose ... my goal in these posts is to introduce the minimal set of tools necessary to accomplish the task ... anyway thank you for your suggestion: what if I add a note suggesting the user can accomplish image creation using the wildfly-maven-plugin? (#8 - I would work on this issue myself if you agree)

tommaso-borgato · 2025-01-29T09:20:29Z

@jamezp Thank you for your review, do you think we can merge this one and wildfly/wildfly.org#671?

tommaso-borgato added 9 commits September 24, 2024 18:51

REST Client + JWT Example

4deace2

Failed attempt to use OIDC + Keycloak

69b9042

Succesful attempt to use OIDC + Keycloak

b401415

simple-microservice-rest-client: step1

c33e2e0

simple-microservice-rest-client: step2

b91b8f4

simple-microservice-rest-client: step3

8a5c04f

simple-microservice-rest-client: step3 - realm

ae8cb3f

simple-microservice-rest-client: step3 - keycloak

545897a

simple-microservice-rest-client: step3 - cleanup

839dfd5

tommaso-borgato mentioned this pull request Oct 17, 2024

WildFly mini series: REST Client wildfly/wildfly.org#671

Open

jamezp self-requested a review November 12, 2024 22:58

jamezp reviewed Nov 13, 2024

View reviewed changes

tommaso-borgato force-pushed the wildfly-mini-serie-client-service branch 5 times, most recently from 1999754 to d9fb804 Compare November 29, 2024 15:18

jamezp reviewed Jan 16, 2025

View reviewed changes

simple-microservice-rest-client: review

78b5166

tommaso-borgato force-pushed the wildfly-mini-serie-client-service branch from d9fb804 to 78b5166 Compare January 20, 2025 14:41

tommaso-borgato requested a review from jamezp February 10, 2025 08:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wildfly mini serie client service #4

Wildfly mini serie client service #4

tommaso-borgato commented Oct 17, 2024 •

edited

Loading

tommaso-borgato commented Nov 7, 2024

jamezp left a comment

jamezp Nov 12, 2024

jamezp Nov 12, 2024

jamezp Nov 13, 2024

jamezp Nov 13, 2024

jamezp Nov 13, 2024

jamezp Nov 13, 2024

tommaso-borgato Nov 29, 2024

jamezp Nov 13, 2024

jamezp Nov 13, 2024

tommaso-borgato commented Nov 29, 2024

tommaso-borgato commented Nov 29, 2024

tommaso-borgato commented Dec 23, 2024

jamezp commented Dec 23, 2024

tommaso-borgato commented Jan 16, 2025

jamezp left a comment

jamezp Jan 16, 2025

jamezp Jan 16, 2025

jamezp Jan 16, 2025

jamezp Jan 16, 2025

jamezp Jan 16, 2025

jamezp Jan 16, 2025

jamezp Jan 16, 2025

jamezp Jan 16, 2025

jamezp Jan 16, 2025

jamezp Jan 16, 2025

tommaso-borgato commented Jan 20, 2025 •

edited

Loading

tommaso-borgato commented Jan 29, 2025

		<version.wildfly.maven.plugin>5.0.1.Final</version.wildfly.maven.plugin>
		<version.wildfly.bom>34.0.1.Final</version.wildfly.bom>

Wildfly mini serie client service #4

Are you sure you want to change the base?

Wildfly mini serie client service #4

Conversation

tommaso-borgato commented Oct 17, 2024 • edited Loading

tommaso-borgato commented Nov 7, 2024

jamezp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tommaso-borgato commented Nov 29, 2024

tommaso-borgato commented Nov 29, 2024

tommaso-borgato commented Dec 23, 2024

jamezp commented Dec 23, 2024

tommaso-borgato commented Jan 16, 2025

jamezp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tommaso-borgato commented Jan 20, 2025 • edited Loading

tommaso-borgato commented Jan 29, 2025

tommaso-borgato commented Oct 17, 2024 •

edited

Loading

tommaso-borgato commented Jan 20, 2025 •

edited

Loading