Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFCORE-6649][WFCORE-6653] Deprecate --no-resol-local-cache and replace it with --… #5810

Merged
merged 2 commits into from
Jan 5, 2024
Merged

[WFCORE-6649][WFCORE-6653] Deprecate --no-resol-local-cache and replace it with --… #5810

merged 2 commits into from
Jan 5, 2024

Conversation

yersan
Copy link
Collaborator

@yersan yersan commented Dec 21, 2023 •
edited
Loading

…use-default-local-cache. Fix minor help installer descriptions

Jira issue: https://issues.redhat.com/browse/WFCORE-6649
Jira issue: https://issues.redhat.com/browse/WFCORE-6653

--no-resol-local-cache gets deprecated and changes its default value to true.

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Dec 21, 2023
@wildfly-ci
Copy link

Core -> Full Integration Build 13344 outcome was UNKNOWN using a merge of 2339eec
Summary: Canceled (Tests passed: 4397, ignored: 61; exit code 143 (Step: Build & test full (Maven)) (new)) Build time: 00:40:44

@wildfly-ci
Copy link

Core -> WildFly Preview Integration Build 13179 outcome was UNKNOWN using a merge of 2339eec
Summary: Canceled (Tests passed: 2022, ignored: 20; exit code 143 (Step: Build & test full (Maven)) (new)) Build time: 00:40:44

@wildfly-ci
Copy link

Core -> Full Integration Build 13113 outcome was UNKNOWN using a merge of 2339eec
Summary: Canceled (Tests passed: 1602, ignored: 33; exit code 143 (Step: Build & test full (Maven)) (new)) Build time: 00:40:44

@yersan yersan changed the title [WFCORE-6649] Deprecate --no-resol-local-cache and replace it with --… [WFCORE-6649][WFCORE-6653] Deprecate --no-resol-local-cache and replace it with --… Dec 21, 2023
@darranl darranl requested a review from jfdenise January 5, 2024 10:25
jfdenise
jfdenise reviewed Jan 5, 2024
View reviewed changes
installation-manager/src/main/java/org/wildfly/core/instmgr/cli/UpdateCommand.java
@@ -38,8 +39,10 @@ public class UpdateCommand extends AbstractInstMgrCommand {
private List<String> repositories;
@Option(name = "local-cache")
private File localCache;
@Option(name = "no-resolve-local-cache", hasValue = false)
@Option(name = NO_RESOLVE_LOCAL_CACHE_OPTION, hasValue = false, activator = AbstractInstMgrCommand.NoResolveLocalCacheActivator.class, defaultValue = "true")
Copy link
Contributor

@jfdenise jfdenise Jan 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor comment, this option has no value, setting the default value to true is not needed.

jfdenise
jfdenise approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@jfdenise jfdenise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a comment but this shouldn't block the merge.

@darranl
Copy link
Contributor

darranl commented Jan 5, 2024

Thank you for the review @jfdenise

@darranl darranl merged commit df80b7d into wildfly:main Jan 5, 2024
12 checks passed
@yersan yersan deleted the WFCORE-6649 branch January 8, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfdenise jfdenise jfdenise approved these changes

Assignees
No one assigned
Labels
deps-ok Dependencies have been checked, and there are no significant changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yersan @wildfly-ci @darranl @jfdenise