Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFCORE-6538] Prepare test suite for upcoming JBoss Remoting & XNIO releases #5830

Merged
merged 2 commits into from
Jan 15, 2024
Merged

[WFCORE-6538] Prepare test suite for upcoming JBoss Remoting & XNIO releases #5830

merged 2 commits into from
Jan 15, 2024

Conversation

ropalka
Copy link
Contributor

@ropalka ropalka commented Jan 12, 2024

@ropalka
Revert "[WFCORE-6538] ClosedChannelException is thrown intermittently…
dd2ca88 
… instead of SaslException when using GS2_KRB5 with TLS"

This reverts commit 4bda982.
@wildfly-ci
Copy link

Core -> WildFly Preview Integration Build 13227 outcome was FAILURE using a merge of aad40bc
Summary: Compilation error: Compiler (new) Build time: 00:01:48

@wildfly-ci
Copy link

Core -> Full Integration Build 13164 outcome was FAILURE using a merge of aad40bc
Summary: Compilation error: Compiler (new) Build time: 00:01:50

@wildfly-ci
Copy link

Core -> Full Integration Build 13398 outcome was FAILURE using a merge of aad40bc
Summary: Compilation error: Compiler (new) Build time: 00:01:59

@yersan yersan requested a review from fjuma January 12, 2024 11:22
@yersan yersan added the 23.x label Jan 12, 2024
@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Jan 12, 2024
@ropalka
[WFCORE-6538] Prepare for upcoming JBoss Remoting & XNIO releases whe…
be64de1 
…re peer shut down is propagated to XNIO & Remoting.
fjuma
fjuma reviewed Jan 12, 2024
View reviewed changes
Copy link
Contributor

@fjuma fjuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ropalka! The changes look ok but it would be good to provide some info on why this change is being made, thanks!

@wildfly-ci
Copy link

Core -> Full Integration Build 13399 outcome was FAILURE using a merge of be64de1
Summary: Tests failed: 1 (1 new), passed: 7530, ignored: 136 Build time: 03:37:36

Failed tests

org.eclipse.microprofile.reactive.messaging.tck.channel.overflow.DropOverflowStrategyOverflowTest.testOverflow: java.lang.AssertionError: 
Expecting
  ["1", "2", "895", "998", "999"]
not to contain
  ["999"]
but found
  ["999"]

java.lang.AssertionError: 

Expecting
  ["1", "2", "895", "998", "999"]
not to contain
  ["999"]
but found
  ["999"]

	at deployment.test-11a21654-4d1c-4a77-a3c5-8cebb57b00e0.war//org.eclipse.microprofile.reactive.messaging.tck.channel.overflow.DropOverflowStrategyOverflowTest.testOverflow(DropOverflowStrategyOverflowTest.java:47)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at [email protected]//jakarta.servlet.http.HttpServlet.service(HttpServlet.java:527)
	at [email protected]//jakarta.servlet.http.HttpServlet.service(HttpServlet.java:614)
	at [email protected]//io.undertow.servlet.handlers.ServletHandler.handleRequest(ServletHandler.java:74)

@ropalka
Copy link
Contributor Author

ropalka commented Jan 15, 2024 •
edited
Loading

This change was introduced because with upcoming JBoss XNIO & Remoting versions the ClosedChannelException will be properly propagated up and so it will be thrown in this test.

@yersan yersan added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Jan 15, 2024
fjuma
fjuma approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@fjuma fjuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ropalka!

@yersan yersan merged commit 3d6737d into wildfly:main Jan 15, 2024
11 of 12 checks passed
@ropalka ropalka deleted the WFCORE-6538 branch January 24, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yersan yersan yersan approved these changes

@fjuma fjuma fjuma approved these changes

Assignees
No one assigned
Labels
deps-ok Dependencies have been checked, and there are no significant changes ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ropalka @wildfly-ci @fjuma @yersan