Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-7095][WFCORE-7108][WFCORE-7111][WFCORE-7112][WFCORE-7113][WFCORE-7114] Module identifier in api fixes #6301

Merged
merged 11 commits into from
Dec 23, 2024

Conversation

bstansberry
Copy link
Contributor

@bstansberry bstansberry commented Dec 22, 2024

This is an aggregate of:

#6282
#6293
#6298
#6299
#6300
#6302

In total this deals with what I think are all the places where WF Core exposes ModuleIdentifier in API that full WildFly or an external extension might use. It deprecates all such places and provides an alternative for all but two things that I don't think external modules will use.[1]

I realize this is a lot to deal with at the last minute for WF Core 27, and if it's too much that's ok. Doing this though will give us more freedom to change things right away in Core 28 / WF 36, and gets the deprecation out of the way for downstream. (These APIs are not supported for external use downstream, but we'd likely want to deprecate them anyway before removing them in some future release.)

#6282 is the most substantive. #6293 is already approved. The others are new but pretty simple.

[1] Those two things deprecated without alternatives provided in this PR are:
Attachments.CLASS_PATH_ENTRIES which we should just break (by changing its list element type) with no migration path. It's not used outside the kernel and shouldn't be.
Attachments.ADDITIONAL_ANNOTATION_INDEXES for which we will need to do a simple migration dance in a couple core Betas to let the one 'ee' subsystem use migrate.

@yersan @ropalka @dmlloy FYI.

@wildfly-ci
Copy link

Core -> Full Integration Build 14469 outcome was UNKNOWN using a merge of 120e431
Summary: Canceled (Tests passed: 4187, ignored: 56; Step 5/6) Build time: 01:44:29

@wildfly-ci
Copy link

Core -> Full Integration Build 14167 outcome was UNKNOWN using a merge of 120e431
Summary: Canceled (Tests passed: 2529, ignored: 42; Step 5/6) Build time: 01:44:29

@wildfly-ci
Copy link

Core -> Full Integration Build 14168 outcome was UNKNOWN using a merge of 120e431
Summary: Canceled (Step 3/6) Build time: 00:04:14

@wildfly-ci
Copy link

Core -> Full Integration Build 14169 outcome was UNKNOWN using a merge of 120e431
Summary: Canceled (Step 5/6) Build time: 00:20:17

@wildfly-ci
Copy link

Core -> Full Integration Build 14170 outcome was UNKNOWN using a merge of 120e431
Summary: Canceled (Step 3/6) Build time: 00:01:50

@wildfly-ci

This comment was marked as off-topic.

@bstansberry bstansberry changed the title [WFCORE-7095][WFCORE-7108][WFCORE-7111][WFCORE-7112][WFCORE-7113]Module identifier in api fixes [WFCORE-7095][WFCORE-7108][WFCORE-7111][WFCORE-7112][WFCORE-7113][WFCORE-7114] Module identifier in api fixes Dec 22, 2024
@wildfly-ci
Copy link

Core -> WildFly Preview Integration Build 14256 outcome was UNKNOWN using a merge of 60a3f32
Summary: Canceled (Tests passed: 1436, ignored: 13; Step 5/6) Build time: 00:24:08

@wildfly-ci
Copy link

Core -> Full Integration Build 14173 outcome was UNKNOWN using a merge of 60a3f32
Summary: Canceled (Tests passed: 2138, ignored: 38; Step 5/6) Build time: 00:49:48

@wildfly-ci

This comment was marked as off-topic.

@yersan
Copy link
Collaborator

yersan commented Dec 23, 2024

"Windows - JDK 11 (Pull Request) - merge" failure seems unrelated, same error trace in other Jobs

@yersan yersan merged commit 51dd629 into wildfly:main Dec 23, 2024
11 of 13 checks passed
@yersan
Copy link
Collaborator

yersan commented Dec 23, 2024

Thanks @bstansberry

@bstansberry bstansberry deleted the ModuleIdentifier_in_API branch January 2, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants