Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-7124] Remove use of server-side Stability type from the CLI #6309

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

bstansberry
Copy link
Contributor

@wildfly wildfly deleted a comment from wildfly-ci Jan 2, 2025
@wildfly-ci

This comment was marked as off-topic.

@wildfly wildfly deleted a comment from wildfly-ci Jan 7, 2025
@wildfly-ci

This comment was marked as outdated.

@wildfly wildfly deleted a comment from wildfly-ci Jan 12, 2025
@wildfly wildfly deleted a comment from wildfly-ci Jan 12, 2025
@wildfly wildfly deleted a comment from wildfly-ci Jan 12, 2025
@wildfly wildfly deleted a comment from wildfly-ci Jan 12, 2025
@wildfly wildfly deleted a comment from wildfly-ci Jan 14, 2025
@bstansberry
Copy link
Contributor Author

@jfdenise and @yersan If we don't like this approach we can just drop the tab completion suggestion and the user must know what to type. The protocol. controller-client, cli and embedded modules are client-side modules and can't have deps on server-side modules. Those four should be able to have an independent lifecycle (e.g. we should be able to put them in a separate code base from all the server side code.) Also, as the TODO I removed hints, suggesting all options is incorrect as the process being embedded may only support 'default'. But EmbedServerHandler and EmbedHostController handler can't know when making suggestions what the process will support if the CLI isn't running as a modular app in the same installation as the eventual embedded process. The only way to know is to accept the user's jboss-home input and find the target installation.

@wildfly-ci

This comment was marked as off-topic.

@wildfly-ci

This comment was marked as off-topic.

@wildfly-ci

This comment was marked as off-topic.

@yersan yersan added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Jan 20, 2025
@yersan yersan merged commit 5ebb2c3 into wildfly:main Jan 20, 2025
10 of 13 checks passed
@yersan
Copy link
Collaborator

yersan commented Jan 20, 2025

Thanks @bstansberry @jfdenise

@bstansberry bstansberry deleted the WFCORE-7124 branch January 20, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants