Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Electron v13-14 and Node v16 #358

Merged
merged 5 commits into from
Sep 11, 2021

Conversation

ykhwong
Copy link
Contributor

@ykhwong ykhwong commented Sep 3, 2021

Support Electron v13-14 and Node v16

@quuu
Copy link

quuu commented Sep 6, 2021

bump please ^

https://nodejs.org/en/about/releases/
Currently supported versions of Node.js: v12 through v16

https://www.electronjs.org/docs/tutorial/support
Currently supported versions of Electron: v12, v13, and v14
@ykhwong
Copy link
Contributor Author

ykhwong commented Sep 10, 2021

If we don't use AppVeyor anymore, please consider deleting AppVeyor's webhook from the repo setting.

@ash0x0
Copy link
Collaborator

ash0x0 commented Sep 10, 2021

@ykhwong did you test using this? platform, env?

@ykhwong
Copy link
Contributor Author

ykhwong commented Sep 10, 2021

Yes, I tested with electron abi-89 and win10 x86_64 and confirmed it to work. I don't have a testing environment for the other platforms for now.

@ash0x0 ash0x0 merged commit 2297744 into wilix-team:master Sep 11, 2021
@sonukapoor
Copy link

@ykhwong Would you mind providing a fix for 15 as well? I am sure a lot of people will appreciate that.

@ykhwong
Copy link
Contributor Author

ykhwong commented Dec 29, 2022

@ykhwong Would you mind providing a fix for 15 as well? I am sure a lot of people will appreciate that.

You can find it here: #363

@sonukapoor
Copy link

Thanks @ykhwong. Does this also fix the non-context-aware error mentioned here?

#387

@ykhwong
Copy link
Contributor Author

ykhwong commented Dec 29, 2022

Thanks @ykhwong. Does this also fix the non-context-aware error mentioned here?

#387

I don't think so.

@sonukapoor
Copy link

@ykhwong Any idea how to fix this?

@ykhwong
Copy link
Contributor Author

ykhwong commented Dec 30, 2022

@sonukapoor I haven't encountered the 'non-context-aware' error with the pull request branch ykhwong:update-electron-v15, so I have no idea how to fix it.

@sonukapoor
Copy link

@ykhwong If you try to load the module in the renderer you should see an error. The solution is to use NAN_MODULE_WORKER_ENABLED as mentioned in the linked PR. @marcelblum mentioned though that the clean up is missing, so the PR is sitting there for an C++ expert to come and help.

@marcelblum
Copy link
Contributor

@sonukapoor sad to say but unfortunately you're better off just using the actively maintained uiohook-napi which works well in latest Electron. iohook seems to be dead.

@sonukapoor
Copy link

@marcelblum Do you know how to use this within the Electron renderer?

@marcelblum
Copy link
Contributor

@sonukapoor uiohook-napi works just like iohook, almost a drop-in replacement. I found a few keycodes were different in certain platform-specific situations but that was pretty much the only difference. uiohook-napi binds to the same uiohook library.

@sonukapoor
Copy link

@marcelblum I was trying to load this using __non_webpack_require and the prebuilt version for windows, but it doesnt seem to work. I get the node.napi.node is not a valid Win32 application. I will try to import it directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants