-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Electron v13-14 and Node v16 #358
Conversation
bump please ^ |
https://nodejs.org/en/about/releases/ Currently supported versions of Node.js: v12 through v16 https://www.electronjs.org/docs/tutorial/support Currently supported versions of Electron: v12, v13, and v14
If we don't use AppVeyor anymore, please consider deleting AppVeyor's webhook from the repo setting. |
@ykhwong did you test using this? platform, env? |
Yes, I tested with electron abi-89 and win10 x86_64 and confirmed it to work. I don't have a testing environment for the other platforms for now. |
@ykhwong Would you mind providing a fix for 15 as well? I am sure a lot of people will appreciate that. |
@ykhwong Any idea how to fix this? |
@sonukapoor I haven't encountered the 'non-context-aware' error with the pull request branch ykhwong:update-electron-v15, so I have no idea how to fix it. |
@ykhwong If you try to load the module in the renderer you should see an error. The solution is to use |
@sonukapoor sad to say but unfortunately you're better off just using the actively maintained uiohook-napi which works well in latest Electron. iohook seems to be dead. |
@marcelblum Do you know how to use this within the Electron renderer? |
@sonukapoor uiohook-napi works just like iohook, almost a drop-in replacement. I found a few keycodes were different in certain platform-specific situations but that was pretty much the only difference. uiohook-napi binds to the same uiohook library. |
@marcelblum I was trying to load this using |
Support Electron v13-14 and Node v16