Prevent a reentrancy bug

william-dowling · Oct 4, 2021 · c667cd1 · c667cd1
1 parent 0060ce7
commit c667cd1
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/server/src/annotation.py b/server/src/annotation.py
@@ -1240,13 +1240,14 @@ def save(self, document=None):
                     tmp_file.flush()
 
                     try:
-                        with Annotations(tmp_file.name) as ann:
+                        # read only, because we write manually using copyfile; this prevents certain reentrant errors
+                        with Annotations(tmp_file.name, read_only=True) as ann:
                             # Move the temporary file onto the old file
                             copyfile(tmp_file.name, self._input_files[0])
                             # As a matter of convention we adjust the modified
                             # time of the data dir when we write to it. This
                             # helps us to make back-ups
-                            time()
+                            # time()
                             # XXX: Disabled for now!
                             #utime(DATA_DIR, (now, now))
                     except Exception as e: