ffmpeg: Enable avfilter and avformat for gst-libav #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Previously, gst-libav failed to build due to absence of avfilter and avformat libraries from ffmpeg. This commit enables those libraries by fixing the build error with unistd.h. This imports a patch for zlib from vcpkg[^1] to fix the unistd.h check. In gvsbuild, zlib is build using nmake which copies the zconf.h file. So, the imported patch file was modified for zconf.h only. [^1]: https://github.com/microsoft/vcpkg/blob/master/ports/zlib/0001-Prevent-invalid-inclusions-when-HAVE_-is-set-to-0.patch
Biswa96
force-pushed
the
fix-gst-libav
branch
from
31960b2 to
6fc5733
Compare
|
Hi @Biswa96, thanks so much for thinking of us! This looks great. Do you know if someone tried to submit this upstream to the zlib repo? |
danyeaw
approved these changes
Feb 13, 2025
|
No. |
|
Ok, let me at least try to see if I can get it accepted upstream. |
|
There is an old upstream issue with same problem madler/zlib#787 |
danyeaw
force-pushed
the
fix-gst-libav
branch
from
9a6e363 to
6bcf799
Compare
|
Hi @Biswa96, I simplified the patch syntax to improve readability and submitted a PR upstream to zlib. |
|
Thanks again @Biswa96, this is now fixed upstream with zlib and I brought in the exact patch to Gvsbuild. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, gst-libav failed to build due to absence of avfilter and avformat libraries from ffmpeg. This commit enables those libraries by fixing the build error with unistd.h. This imports a patch for zlib from vcpkg1 to fix the unistd.h check.
In gvsbuild, zlib is build using nmake which copies the zconf.h file. So, the imported patch file was modified for zconf.h only.
Footnotes
https://github.com/microsoft/vcpkg/blob/master/ports/zlib/0001-Prevent-invalid-inclusions-when-HAVE_-is-set-to-0.patch ↩