Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run jvm and android unit tests and aggregating results [WPB-10599] 🍒 #2961

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 20, 2024

BugWPB-10599 Kalium test results are not included in the unittests/integrationtests zip files of android Bund builds

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

some securaty tests are not running when building the android app

Solutions

add 2 gradle tasks that will run jvm and andriud unit tests and aggregate the results

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor Author

github-actions bot commented Aug 20, 2024

Test Results

3 193 tests  ±0   3 088 ✔️ ±0   3m 40s ⏱️ +6s
   548 suites ±0      105 💤 ±0 
   548 files   ±0          0 ±0 

Results for commit 2a9a1ba. ± Comparison against base commit a4c9999.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Aug 20, 2024

Datadog Report

Branch report: ci/run-gradle-android-and-jvm-unit-tests-and-aggregate-results-cherry-pick
Commit report: 7b13186
Test service: kalium-jvm

✅ 0 Failed, 3088 Passed, 105 Skipped, 13.21s Total Time

Copy link

sonarqubecloud bot commented Sep 2, 2024

@MohamadJaara MohamadJaara added this pull request to the merge queue Sep 2, 2024
Merged via the queue into release/candidate with commit 938fee7 Sep 2, 2024
22 checks passed
@MohamadJaara MohamadJaara deleted the ci/run-gradle-android-and-jvm-unit-tests-and-aggregate-results-cherry-pick branch September 2, 2024 08:25
github-actions bot added a commit that referenced this pull request Sep 2, 2024
…] 🍒 (#2961)

* Commit with unresolved merge conflicts

* Update build.gradle.kts

* exclude crypto module

---------

Co-authored-by: Mohamad Jaara <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Sep 5, 2024
…] 🍒 (#2961) (#2984)

* Commit with unresolved merge conflicts

* Update build.gradle.kts

* exclude crypto module

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mohamad Jaara <[email protected]>
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. 👕 size: S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants