Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(migration): pick one-on-one proteus conversation in alphabetically order for MLS migration (WPB-10259) 🍒 #2964

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 22, 2024

BugWPB-10259 [Android] : Duplicate 1:1 conversation - not showing one of the conv

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Based on Product agreement, if the user has multiple Proteus conversation, during the migration we must pick the first one in alphabetically order.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added echoes: unplanned Any work item that isn’t part of the product or technical roadmap. type: bug / fix 🐞 👕 size: S labels Aug 22, 2024
@MohamadJaara MohamadJaara enabled auto-merge August 22, 2024 17:06
Copy link

sonarqubecloud bot commented Sep 4, 2024

Copy link
Contributor Author

github-actions bot commented Sep 4, 2024

Test Results

3 194 tests  +1   3 089 ✔️ +1   3m 52s ⏱️ +29s
   548 suites ±0      105 💤 ±0 
   548 files   ±0          0 ±0 

Results for commit 943170b. ± Comparison against base commit b12a05b.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/pick-oneonone-migration-target-alphabetically-cherry-pick
Commit report: 067feb3
Test service: kalium-jvm

✅ 0 Failed, 3089 Passed, 105 Skipped, 16.02s Total Time

@MohamadJaara MohamadJaara added this pull request to the merge queue Sep 9, 2024
Merged via the queue into release/candidate with commit 3406af8 Sep 9, 2024
22 checks passed
@MohamadJaara MohamadJaara deleted the fix/pick-oneonone-migration-target-alphabetically-cherry-pick branch September 9, 2024 07:29
github-actions bot added a commit that referenced this pull request Sep 9, 2024
…phabetically order (#2962) (#2964)

Co-authored-by: Mojtaba Chenani <[email protected]>
Co-authored-by: Boris Safonov <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Sep 13, 2024
…phabetically order (#2962) (#2964) (#2996)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mojtaba Chenani <[email protected]>
Co-authored-by: Boris Safonov <[email protected]>
Co-authored-by: Mohamad Jaara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. 👕 size: S type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants