Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core-crypto): update CoreCrypto to 1.0.2 (WPB-9118) 🍒 🍒 #2967

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 23, 2024

BugWPB-9118 [Android] User is displayed as unverified if i open details from 1:1 conv

This PR was automatically cherry-picked based on the following PR:

Original PR description:


This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Update CoreCrypto to 1.0.1 to include the fix for generating X509 KeyPackage after E2EI.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Sorry, something went wrong.

Co-authored-by: Mojtaba Chenani <[email protected]>
Co-authored-by: Oussama Hassine <[email protected]>
@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch echoes: unplanned Any work item that isn’t part of the product or technical roadmap. type: chore 🧹 👕 size: S labels Aug 23, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…-cherry-pick
Copy link

Copy link
Contributor Author

github-actions bot commented Aug 29, 2024

Test Results

3 175 tests  ±0   3 070 ✔️ ±0   3m 11s ⏱️ -50s
   545 suites ±0      105 💤 ±0 
   545 files   ±0          0 ±0 

Results for commit b576451. ± Comparison against base commit 9f4a150.

♻️ This comment has been updated with latest results.

Copy link
Contributor Author

🐰Bencher

ReportThu, August 29, 2024 at 07:38:00 UTC
Projectkalium
Branchchore/update-corecrypto-1.0.1-cherry-pick-cherry-pick
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

  • Latency (latency)

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles➖ (view plot)682,815.34
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory➖ (view plot)441,412,939.79
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark➖ (view plot)921,106,836.55
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark➖ (view plot)21,797,995.07

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.52%. Comparing base (9f4a150) to head (b576451).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2967      +/-   ##
===========================================
- Coverage    52.53%   52.52%   -0.02%     
===========================================
  Files         1294     1294              
  Lines        49639    49637       -2     
  Branches      4618     4618              
===========================================
- Hits         26078    26071       -7     
- Misses       21693    21698       +5     
  Partials      1868     1868              

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f4a150...b576451. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: chore/update-corecrypto-1.0.1-cherry-pick-cherry-pick
Commit report: 6cf47cc
Test service: kalium-jvm

✅ 0 Failed, 3070 Passed, 105 Skipped, 9.77s Total Time

@ohassine ohassine added this pull request to the merge queue Aug 29, 2024
Merged via the queue into develop with commit 889708d Aug 29, 2024
22 checks passed
@ohassine ohassine deleted the chore/update-corecrypto-1.0.1-cherry-pick-cherry-pick branch August 29, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch echoes: unplanned Any work item that isn’t part of the product or technical roadmap. 👕 size: S type: chore 🧹
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants