Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: second message edit will fail [WPB-10773] #2976

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Aug 28, 2024

BugWPB-10773 [Android] Messages can only be edited once


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

second message edit will fail

Causes (Optional)

wrong if condition

Solutions

reverse the if condition and add tests

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

@MohamadJaara MohamadJaara changed the title fix: second message edit will fail fix: second message edit will fail [WPB-10773] Aug 28, 2024
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Aug 28, 2024
Copy link
Contributor

github-actions bot commented Aug 28, 2024

Test Results

3 181 tests  +1   3 076 ✔️ +1   4m 0s ⏱️ +45s
   545 suites ±0      105 💤 ±0 
   545 files   ±0          0 ±0 

Results for commit c00eb5e. ± Comparison against base commit 501b813.

♻️ This comment has been updated with latest results.

@MohamadJaara MohamadJaara enabled auto-merge August 28, 2024 16:05
@MohamadJaara MohamadJaara added this pull request to the merge queue Aug 28, 2024
@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/second-message-edit-fail
Commit report: 8228a88
Test service: kalium-jvm

✅ 0 Failed, 3076 Passed, 105 Skipped, 12.29s Total Time

Merged via the queue into release/candidate with commit e07247e Aug 28, 2024
25 of 26 checks passed
@MohamadJaara MohamadJaara deleted the fix/second-message-edit-fail branch August 28, 2024 16:41
github-actions bot pushed a commit that referenced this pull request Aug 28, 2024
MohamadJaara added a commit that referenced this pull request Aug 28, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 31, 2024
Co-authored-by: Mohamad Jaara <[email protected]>
Co-authored-by: Yamil Medina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. 👕 size: S type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants