fix(mls-client): skip MLSClient registration if it has registered

[mchenani]

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Check if the MLS Client has registered, then skip the registration.

Issues

When the user logs out without clearing the data, we were trying to register the exist MLSClient again; that lead to an error!

Solutions

If the client has registered before and the user log in again to continue on a previously established session no need to register the client again and simply skip the api call.

Testing

Test Coverage (Optional)

• I have added automated test to this contribution

How to Test

Have a user with MLS Enabled on their team
1- Log in and log out without clearing the data
2- When you try to log in again with the same use, you should be able to proceed successfully

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

Test Results

3 064 tests   2 957 ✔️  3m 24s ⏱️
   524 suites     107 💤
   524 files           0 ❌

Results for commit 443d746.

♻️ This comment has been updated with latest results.

[datadog-wireapp]

Datadog Report

All test runs 77d96f3 🔗

✅ 2 Total Test Services: 0 Failed, 2 Passed

Test Services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Total Time	Test Service View
kalium-ios	0	0	0	2806	123	1.33s	Link
kalium-jvm	0	0	0	2957	107	6.05s	Link

[MohamadJaara]

does clientRegistrationStorage.hasRegisteredMLSClient take into account if the registered client still exists remotely, meaning if my app session expired and during that time the client was removed remotely, will this function still return true?

[mchenani]

That's another edge case, if the use was logged out without clearing the data, and delete the client from another device and afterwards tries to login on this device we can't detect it.
What we can do:
Currently if the client is registered, we get this error from the server API:
InvalidRequestError(errorResponse=ErrorResponse(code=400, message=MLS public key for the given signature scheme already exists, label=mls-duplicate-public-key))
We can instead of checking the local flag always try to register the client against the server, if we get that error then we ignore it.

Wdyt?

[MohamadJaara]

For Proteus, we already check if the local client still exists remotely or not, I suggest MLS clients follow the same path as Proteus

[mchenani]

Closing this: decided to go with another solution #2987