Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: GetNextAudioMessageInConversationUseCase WPB-11725 #3191

Merged

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Dec 20, 2024

StoryWPB-11725 [Android] Playback improvement - 2 - Auto playback/Background play

better to merge after #3186

What's new in this PR?

Issues

No any UseCase to get a next AudioMessage that goes after just played message.

Causes (Optional)

Needed for audio message playback.

Solutions

Added GetNextAudioMessageInConversationUseCase to get a next AudioMessage that goes after just played message.

@borichellow borichellow self-assigned this Dec 20, 2024
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Dec 20, 2024
@borichellow borichellow changed the base branch from develop to feat/add_get_sender_name_by_message_id_use_case December 20, 2024 15:20
Base automatically changed from feat/add_get_sender_name_by_message_id_use_case to develop December 23, 2024 12:00
Copy link
Contributor

github-actions bot commented Dec 23, 2024

Test Results

3 371 tests  +5   3 264 ✅ +5   5m 42s ⏱️ -8s
  578 suites +1     107 💤 ±0 
  578 files   +1       0 ❌ ±0 

Results for commit 47045db. ± Comparison against base commit 3c7855a.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@borichellow borichellow added this pull request to the merge queue Dec 23, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 13.33333% with 13 lines in your changes missing coverage. Please review.

Project coverage is 54.12%. Comparing base (3c7855a) to head (47045db).

Files with missing lines Patch % Lines
...essage/GetNextAudioMessageInConversationUseCase.kt 0.00% 10 Missing ⚠️
...ire/kalium/logic/data/message/MessageRepository.kt 0.00% 1 Missing ⚠️
.../wire/kalium/logic/feature/message/MessageScope.kt 0.00% 1 Missing ⚠️
...e/kalium/persistence/dao/message/MessageDAOImpl.kt 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3191      +/-   ##
===========================================
- Coverage    54.13%   54.12%   -0.01%     
===========================================
  Files         1261     1262       +1     
  Lines        36748    36756       +8     
  Branches      3734     3734              
===========================================
+ Hits         19893    19894       +1     
- Misses       15417    15422       +5     
- Partials      1438     1440       +2     
Files with missing lines Coverage Δ
.../wire/kalium/persistence/dao/message/MessageDAO.kt 100.00% <ø> (ø)
...ire/kalium/logic/data/message/MessageRepository.kt 49.21% <0.00%> (-0.20%) ⬇️
.../wire/kalium/logic/feature/message/MessageScope.kt 0.00% <0.00%> (ø)
...e/kalium/persistence/dao/message/MessageDAOImpl.kt 70.63% <66.66%> (-0.05%) ⬇️
...essage/GetNextAudioMessageInConversationUseCase.kt 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c7855a...47045db. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: feat/get_next_audio_message_in_conversation_use_case
Commit report: ae9db44
Test service: kalium-jvm

✅ 0 Failed, 3264 Passed, 107 Skipped, 1m 2.46s Total Time

Merged via the queue into develop with commit ecdca03 Dec 23, 2024
23 checks passed
@borichellow borichellow deleted the feat/get_next_audio_message_in_conversation_use_case branch December 23, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. 🚨 Potential breaking changes 👕 size: M type: feature ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants