-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: MLS groups are not usable if I have a proteus client registered to my account but have MLS on current client [WPB-15192] 🍒 #3204
Conversation
…to my account but have MLS on current client [WPB-15192] (#3197) * fix: MLS groups are not usable if I have a proteus client registered to my account but have MLS on current client [WPB-15192] * detekt * detekt * fix: pr comments --------- Co-authored-by: yamilmedina <[email protected]>
…user-have-1-mls-client-after-migration-cherry-pick
Quality Gate passedIssues Measures |
Test Results3 384 tests +5 3 276 ✅ +4 5m 27s ⏱️ -7s Results for commit d335eff. ± Comparison against base commit f00dd3f. This pull request skips 1 test.
♻️ This comment has been updated with latest results. |
Bencher Report
Click to view all benchmark results
|
Datadog ReportBranch report: ✅ 0 Failed, 3276 Passed, 108 Skipped, 1m 1.1s Total Time |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3204 +/- ##
========================================
Coverage 54.11% 54.12%
========================================
Files 1264 1264
Lines 36818 36829 +11
Branches 3738 3738
========================================
+ Hits 19925 19934 +9
- Misses 15451 15454 +3
+ Partials 1442 1441 -1
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
the current client can be MLS capable but it did not announce it yet to the backend (migration is not forced yet)
Solutions
instead of looking at the user in general to know if interactions are allowed only look at the current client
this will result to the current client ignoring any Proteus self clients when sending but this is an acceptable case
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.