fix: update common protocol resolution (WPB-15191) 🍒

[github-actions]

WPB-15191 [Android] User can not create or see MLS conversations, when they still have a proteus client registered to their account

This PR was automatically cherry-picked based on the following PR:

• fix: update common protocol resolution (WPB-15191) #3208

Original PR description:

---

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

Resolving protocol for 1:1 was incorrectly taking in consideration teamDefault Protocol

Causes (Optional)

When the migration to MLS is not completed, and I have still valid Proteus clients around. The resolution of these conversations, new or existing, was not possible.

Solutions

Since this was introduced for another bug, that now we are taking care by creating the MLS client at the right moment.
We roll back those lines, see.

• fix(mls): respect default protocol in one-on-one conversation initialisation (WPB-8975) 🍒 🍒 #2787

• GitHub link to other pull request

Testing

Test Coverage (Optional)

• I have added automated test to this contribution

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Test Results

3 375 tests   - 3   3 268 ✅  - 3   5m 49s ⏱️ -24s
  580 suites ±0     107 💤 ±0 
  580 files   ±0       0 ❌ ±0 

Results for commit a5e6c38. ± Comparison against base commit 1adf523.

This pull request removes 3 tests.

com.wire.kalium.logic.feature.protocol.OneOnOneProtocolSelectorTest ‑ givenSelfUserDoesntSupportsDefaultProtocolButOtherUserDoes_thenShouldReturnNoCommonProtocol[jvm]
com.wire.kalium.logic.feature.protocol.OneOnOneProtocolSelectorTest ‑ givenSelfUserSupportsDefaultProtocolButOtherUserDoesnt_thenShouldReturnNoCommonProtocol[jvm]
com.wire.kalium.logic.feature.protocol.OneOnOneProtocolSelectorTest ‑ givenUsersHaveProtocolInCommonButDiffersWithDefaultProtocol_thenShouldReturnNoCommonProtocol[jvm]

♻️ This comment has been updated with latest results.

[github-actions]

Bencher Report

Branch	fix/common-protocol-resolution-cherry-pick
Testbed	ubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

• Latency (nanoseconds (ns))

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results

Benchmark	Latency	microseconds (µs)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles	📈 view plot ⚠️ NO THRESHOLD	686.47
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory	📈 view plot ⚠️ NO THRESHOLD	602,080.13
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark	📈 view plot ⚠️ NO THRESHOLD	1,345,815.56
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark	📈 view plot ⚠️ NO THRESHOLD	21,862.41

🐰 View full continuous benchmarking report in Bencher

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.11%. Comparing base (1adf523) to head (a5e6c38).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3210   +/-   ##
========================================
  Coverage    54.10%   54.11%           
========================================
  Files         1264     1264           
  Lines        36802    36806    +4     
  Branches      3735     3735           
========================================
+ Hits         19913    19917    +4     
  Misses       15449    15449           
  Partials      1440     1440           

Files with missing lines	Coverage Δ
...logic/feature/protocol/OneOnOneProtocolSelector.kt	91.30% <100.00%> (+1.83%)	⬆️

... and 2 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1adf523...a5e6c38. Read the comment docs.

[datadog-wireapp]

Datadog Report

Branch report: fix/common-protocol-resolution-cherry-pick
Commit report: a2b5c09
Test service: kalium-jvm

✅ 0 Failed, 3268 Passed, 107 Skipped, 1m 3.74s Total Time