Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove conversation from folder [WPB-14630] #3230

Merged
merged 4 commits into from
Jan 15, 2025

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Jan 15, 2025

BugWPB-14630 [Android] Conversation folder - Remove from folder


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • remove conversation from folder
  • migrated LabeledConversation to not use Conversation foreign key to fix issue with syncing labeled conversations with not existing conversation

@Garzas Garzas self-assigned this Jan 15, 2025
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Jan 15, 2025
Copy link
Contributor

github-actions bot commented Jan 15, 2025

Test Results

3 401 tests  +8   3 293 ✅ +8   5m 45s ⏱️ -4s
  584 suites +1     108 💤 ±0 
  584 files   +1       0 ❌ ±0 

Results for commit 1e2cfee. ± Comparison against base commit 2a6796a.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Jan 15, 2025

Datadog Report

Branch report: feat/remove-conversation-from-folder
Commit report: e685ec4
Test service: kalium-jvm

✅ 0 Failed, 3293 Passed, 108 Skipped, 1m 2.63s Total Time

Copy link
Contributor

github-actions bot commented Jan 15, 2025

@MohamadJaara MohamadJaara added this pull request to the merge queue Jan 15, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 70.96774% with 9 lines in your changes missing coverage. Please review.

Project coverage is 54.47%. Comparing base (2a6796a) to head (1e2cfee).

Files with missing lines Patch % Lines
...o/conversation/folder/ConversationFolderDAOImpl.kt 28.57% 4 Missing and 1 partial ⚠️
...ao/conversation/folder/ConversationFolderEntity.kt 0.00% 3 Missing ⚠️
...um/logic/feature/conversation/ConversationScope.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3230      +/-   ##
===========================================
+ Coverage    54.46%   54.47%   +0.01%     
===========================================
  Files         1268     1269       +1     
  Lines        36927    36958      +31     
  Branches      3744     3745       +1     
===========================================
+ Hits         20113    20134      +21     
- Misses       15402    15411       +9     
- Partials      1412     1413       +1     
Files with missing lines Coverage Δ
...nversation/folders/ConversationFolderRepository.kt 87.14% <100.00%> (+0.57%) ⬆️
...tion/folder/RemoveConversationFromFolderUseCase.kt 100.00% <100.00%> (ø)
...um/logic/feature/conversation/ConversationScope.kt 0.00% <0.00%> (ø)
...ao/conversation/folder/ConversationFolderEntity.kt 84.21% <0.00%> (-15.79%) ⬇️
...o/conversation/folder/ConversationFolderDAOImpl.kt 70.42% <28.57%> (-4.58%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a6796a...1e2cfee. Read the comment docs.

Merged via the queue into develop with commit b304f30 Jan 15, 2025
23 checks passed
@MohamadJaara MohamadJaara deleted the feat/remove-conversation-from-folder branch January 15, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. 🚨 Potential breaking changes 👕 size: L type: feature ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants