Skip to content

Commit

Permalink
feat: detekt fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
yamilmedina committed Jan 24, 2025
1 parent 78a02eb commit 790131f
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
*/
package com.wire.android.ui.authentication.login

import android.annotation.SuppressLint
import androidx.compose.foundation.Image
import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Box
Expand All @@ -37,7 +36,7 @@ import com.wire.android.ui.theme.wireDarkColorScheme
import com.wire.android.util.ui.PreviewMultipleThemes

@Composable
fun WireAuthBackgroundLayout(
fun WireAuthBackgroundLayout(
modifier: Modifier = Modifier,
content: @Composable BoxScope.() -> Unit = {},
) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,8 @@ fun NewLoginContainer(
content()
}
}
}) { _ -> }
}
) { _ -> }
}

@Composable
Expand Down Expand Up @@ -144,7 +145,6 @@ private fun PreviewNewLoginHeader() = WireTheme {
NewLoginHeader("Enter your password to log in", true) {}
}


@PreviewMultipleThemes
@Composable
private fun PreviewNewLoginContent() = WireTheme {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ import androidx.compose.ui.Alignment
import androidx.compose.ui.ExperimentalComposeUiApi
import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.vector.ImageVector
import androidx.compose.ui.platform.LocalContext
import androidx.compose.ui.platform.testTag
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.res.vectorResource
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,9 @@ import kotlin.time.Duration.Companion.seconds
navArgsDelegate = LoginNavArgs::class
)
@Composable
// this is a temporary solution because annotation argument "start" must be a compile-time constant
// TODO: remove this composable as well when removing old WelcomeScreen and set start = true for NewWelcomeScreen
fun WelcomeChooserScreen(navigator: Navigator) {
// this is a temporary solution because annotation argument "start" must be a compile-time constant
// TODO: remove this composable as well when removing old WelcomeScreen and set start = true for NewWelcomeScreen
LaunchedEffect(Unit) {
val destination = if (BuildConfig.ENTERPRISE_LOGIN_ENABLED) NewWelcomeScreenDestination else WelcomeScreenDestination
navigator.navigate(NavigationCommand(destination))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,5 +94,4 @@ class ValidateEmailOrSSOCodeUseCaseTest {

fun arrange() = this to ValidateEmailOrSSOCodeUseCase(validateEmailUseCase, validateSSOCodeUseCase)
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ object PopUpNavigationAnimation : WireDestinationStyleAnimated, BackgroundStyle

object AuthSlideNavigationAnimation : WireDestinationStyleAnimated, BackgroundStyle {
override fun animationType(): TransitionAnimationType = TransitionAnimationType.SLIDE
override fun backgroundType(): BackgroundType = BackgroundType.Auth
override fun backgroundType(): BackgroundType = BackgroundType.Auth
}

object AuthPopUpNavigationAnimation : WireDestinationStyleAnimated, BackgroundStyle {
override fun animationType(): TransitionAnimationType = TransitionAnimationType.POP_UP
override fun backgroundType(): BackgroundType = BackgroundType.Auth
override fun backgroundType(): BackgroundType = BackgroundType.Auth
}

0 comments on commit 790131f

Please sign in to comment.