fix: address comment

wireapp · Jan 10, 2025 · d4dfca8 · d4dfca8
1 parent aa0bce5
commit d4dfca8
Showing 1 changed file with 7 additions and 11 deletions.
diff --git a/app/src/main/kotlin/com/wire/android/util/CurrentScreenManager.kt b/app/src/main/kotlin/com/wire/android/util/CurrentScreenManager.kt
@@ -123,26 +123,22 @@ class CurrentScreenManager @Inject constructor(
     }
 
     override fun onDestinationChanged(controller: NavController, destination: NavDestination, arguments: Bundle?) {
-        val currentView = currentScreenState.value
-        handleViewAction(currentView) { screenName ->
-            AnonymousAnalyticsManagerImpl.stopView(screenName)
-        }
+        val currentScreenName = currentScreenName()
+        AnonymousAnalyticsManagerImpl.stopView(currentScreenName)
+
         val currentItem = destination.toDestination()
         currentScreenState.value = CurrentScreen.fromDestination(
             currentItem,
             arguments,
             isApplicationVisibleFlow.value
         )
 
-        val newView = currentScreenState.value
-        handleViewAction(newView) { screenName ->
-            AnonymousAnalyticsManagerImpl.recordView(screenName)
-        }
+        val newScreenName = currentScreenName()
+        AnonymousAnalyticsManagerImpl.recordView(newScreenName)
     }
 
-    private fun handleViewAction(screen: CurrentScreen, action: (String) -> Unit) {
-        val screenName = (screen as? CurrentScreen.SomeOther)?.route ?: screen.javaClass.simpleName
-        action(screenName)
+    private fun currentScreenName() = currentScreenState.value.let { currentScreen ->
+        (currentScreen as? CurrentScreen.SomeOther)?.route ?: currentScreen.javaClass.simpleName
     }
 
     override fun onCreate(owner: LifecycleOwner) {