Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove un-needed changes #2634

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

mchenani
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Remove two changes wasn't meant to be on candidate.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@mchenani mchenani requested a review from ohassine January 26, 2024 13:22
@mchenani mchenani requested a review from borichellow January 26, 2024 13:22
@mchenani mchenani changed the title chore: remove un-needed changes from Release Candidate branch chore: remove un-needed changes Jan 26, 2024
@ohassine ohassine enabled auto-merge (squash) January 26, 2024 13:28
@ohassine ohassine merged commit 847af47 into release/candidate Jan 26, 2024
10 of 11 checks passed
@AndroidBob AndroidBob mentioned this pull request Jan 26, 2024
6 tasks
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2781 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina deleted the release/remove-unneeded-changes branch July 30, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants