Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: audio converting time - rc 4.7 [WPB-9705] 🍒 #3133

Closed

Conversation

github-actions[bot]
Copy link
Contributor

This PR was automatically cherry-picked based on the following PR:

Original PR description:


BugWPB-9705 [Android] App freezes and delays when sending voice messages


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Cherry pick from fix for develop #3127

Issues

Converting audio file to m4a takes too long

Causes (Optional)

Bad user experience waiting for audio to be encoded

Solutions

  • change audio encoding to wav
  • introduce encoding state to be showed when user recorded long audio file

How to Test

  1. Record long audio file (about 3mins)
  2. After stop it should show Audio encoding message for few seconds
  3. Send audio message

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch size/L labels Jun 27, 2024
@pull-request-size pull-request-size bot added size/M and removed size/L labels Jun 27, 2024
Copy link

@yamilmedina
Copy link
Contributor

I think this PR is not necessary anymore :D

@yamilmedina yamilmedina deleted the fix/rc-audio-converting-time-cherry-pick branch June 27, 2024 07:28
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants