Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: asset restriction [WPB-9947] (#3114) #3147

Merged
merged 6 commits into from
Jul 2, 2024
Merged

fix: asset restriction [WPB-9947] (#3114) #3147

merged 6 commits into from
Jul 2, 2024

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Jul 1, 2024 •
edited by github-actions bot
Loading

TaskWPB-9947 [Android] Implement asset sending restriction

Co-authored-by: yamilmedina [email protected]

(cherry picked from commit 85d5a1e)

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

asset restriction when sending, was not implemented

Solutions

show a snack bar error messag when sending a restricted file

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@MohamadJaara
fix: asset restriction [AR-3336] (#3114)
c48c4fd 
Co-authored-by: yamilmedina <[email protected]>

(cherry picked from commit 85d5a1e)
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 1, 2024 •
edited
Loading

Test Results

705 tests   705 ✅  5m 44s ⏱️
 99 suites    0 💤
 99 files      0 ❌

Results for commit 46d32e0.

♻️ This comment has been updated with latest results.

@MohamadJaara MohamadJaara changed the title fix: asset restriction [AR-3336] (#3114) fix: asset restriction [WPB-9947] (#3114) Jul 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@MohamadJaara MohamadJaara requested review from a team, typfel, yamilmedina, borichellow, ohassine and saleniuk and removed request for a team July 2, 2024 09:01
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 2, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@MohamadJaara MohamadJaara enabled auto-merge (squash) July 2, 2024 10:59
@MohamadJaara MohamadJaara merged commit 1a35424 into release/cycle-4.5 Jul 2, 2024
14 checks passed
@MohamadJaara MohamadJaara deleted the feat/asset-restriction branch July 2, 2024 11:11
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024

APKs built during tests are available here. Scroll down to Artifacts!

MohamadJaara added a commit that referenced this pull request Jul 2, 2024
@MohamadJaara
fix: asset restriction [WPB-9947] (#3114) (#3147)
366a766 
Signed-off-by: MohamadJaara <[email protected]>

(cherry picked from commit 1a35424)
MohamadJaara added a commit that referenced this pull request Jul 3, 2024
@MohamadJaara
fix: asset restriction [WPB-9947] (#3114) (#3147) (#3150)
0f8ae93
MohamadJaara added a commit that referenced this pull request Jul 3, 2024
@MohamadJaara
fix: asset restriction [WPB-9947] (#3114) (#3147)
af160c3 
Signed-off-by: MohamadJaara <[email protected]>

(cherry picked from commit 1a35424)
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitorhugods vitorhugods vitorhugods approved these changes

@alexandreferris alexandreferris alexandreferris approved these changes

@typfel typfel Awaiting requested review from typfel typfel was automatically assigned from wireapp/android

@yamilmedina yamilmedina Awaiting requested review from yamilmedina yamilmedina was automatically assigned from wireapp/android

@borichellow borichellow Awaiting requested review from borichellow borichellow was automatically assigned from wireapp/android

@ohassine ohassine Awaiting requested review from ohassine ohassine was automatically assigned from wireapp/android

@saleniuk saleniuk Awaiting requested review from saleniuk saleniuk was automatically assigned from wireapp/android

Assignees

@MohamadJaara MohamadJaara

Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MohamadJaara @alexandreferris @vitorhugods