Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sharing extension for text content (WPB-10466) #3291

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Aug 6, 2024

BugWPB-10466 [Android] sharing text from sharing extension does nothing


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Sharing extension is broken for text.

Causes (Optional)

When importing assets was implemented, this capability was removed without noticing.

Solutions

Add it back.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

Attachments (Optional)

Screen.Recording.2024-08-06.at.11.49.29.mov

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Aug 6, 2024
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Aug 6, 2024
@yamilmedina yamilmedina changed the title fix: sharing text from text extension (WPB-10466) fix: text from sharing extension (WPB-10466) Aug 6, 2024
@yamilmedina yamilmedina changed the title fix: text from sharing extension (WPB-10466) fix: sharing extension for text content (WPB-10466) Aug 6, 2024
@yamilmedina yamilmedina requested review from Garzas, saleniuk, alexandreferris, a team, borichellow and MohamadJaara and removed request for a team August 6, 2024 10:38
Copy link

sonarqubecloud bot commented Aug 6, 2024

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 44.40%. Comparing base (e439ff9) to head (45ceb54).
Report is 2 commits behind head on release/candidate.

Files Patch % Lines
...id/ui/sharing/ImportMediaAuthenticatedViewModel.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3291      +/-   ##
=====================================================
- Coverage              44.56%   44.40%   -0.17%     
=====================================================
  Files                    453      453              
  Lines                  15192    15288      +96     
  Branches                2525     2552      +27     
=====================================================
+ Hits                    6771     6788      +17     
- Misses                  7703     7784      +81     
+ Partials                 718      716       -2     
Files Coverage Δ
.../conversations/sendmessage/SendMessageViewModel.kt 84.07% <100.00%> (+5.29%) ⬆️
...id/ui/sharing/ImportMediaAuthenticatedViewModel.kt 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e439ff9...45ceb54. Read the comment docs.

Copy link
Contributor

github-actions bot commented Aug 6, 2024

Built wire-android-staging-compat-pr-3291.apk is available for download

Copy link
Contributor

github-actions bot commented Aug 6, 2024

Built wire-android-internal-compat-pr-3291.apk is available for download

@yamilmedina yamilmedina added this pull request to the merge queue Aug 6, 2024
Merged via the queue into release/candidate with commit f1d68ba Aug 6, 2024
11 of 12 checks passed
@yamilmedina yamilmedina deleted the fix/sharing-text-ext branch August 6, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants