-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Location services availability crash #WPB-11304 🍒 #3572
fix: Location services availability crash #WPB-11304 🍒 #3572
Conversation
…ty-crash-cherry-pick
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3572 +/- ##
=====================================================
- Coverage 45.35% 45.34% -0.02%
=====================================================
Files 470 470
Lines 15717 15723 +6
Branches 2627 2627
=====================================================
+ Hits 7128 7129 +1
- Misses 7839 7844 +5
Partials 750 750
Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3572.apk is available for download |
Co-authored-by: Mateusz Zagórski <[email protected]> Co-authored-by: Oussama Hassine <[email protected]>
This PR was automatically cherry-picked based on the following PR:
Original PR description:
https://wearezeta.atlassian.net/browse/WPB-11304
What's new in this PR?
Issues
When location services were removed from device - checking for their availability is crashing the application
Solutions
We need to try/catch the error.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.