Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Location services availability crash #WPB-11304 🍒 #3572

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 30, 2024

This PR was automatically cherry-picked based on the following PR:

Original PR description:


BugWPB-11304 [Android] C apps on ss4sk device crashing when sharing location

https://wearezeta.atlassian.net/browse/WPB-11304

What's new in this PR?

Issues

When location services were removed from device - checking for their availability is crashing the application

Solutions

We need to try/catch the error.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

sonarqubecloud bot commented Nov 4, 2024

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 45.34%. Comparing base (eb46b41) to head (4efc1e9).

Files with missing lines Patch % Lines
...e/messagecomposer/location/LocationPickerHelper.kt 37.50% 5 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3572      +/-   ##
=====================================================
- Coverage              45.35%   45.34%   -0.02%     
=====================================================
  Files                    470      470              
  Lines                  15717    15723       +6     
  Branches                2627     2627              
=====================================================
+ Hits                    7128     7129       +1     
- Misses                  7839     7844       +5     
  Partials                 750      750              
Files with missing lines Coverage Δ
...e/messagecomposer/location/LocationPickerHelper.kt 71.92% <37.50%> (-6.51%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb46b41...4efc1e9. Read the comment docs.

Copy link
Contributor Author

github-actions bot commented Nov 4, 2024

Built wire-android-staging-compat-pr-3572.apk is available for download

@yamilmedina yamilmedina added this pull request to the merge queue Nov 5, 2024
Merged via the queue into release/candidate with commit 0c4facf Nov 5, 2024
12 of 13 checks passed
@yamilmedina yamilmedina deleted the fix/location-service-availability-crash-cherry-pick branch November 5, 2024 10:15
github-actions bot added a commit that referenced this pull request Nov 5, 2024
Co-authored-by: Mateusz Zagórski <[email protected]>
Co-authored-by: Oussama Hassine <[email protected]>
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants