Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: TestTag for DeviceItem #WPB-9784 #3597

Merged
merged 1 commit into from
Nov 7, 2024
Merged

fix: TestTag for DeviceItem #WPB-9784 #3597

merged 1 commit into from
Nov 7, 2024

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Nov 6, 2024 •
edited by github-actions bot
Loading

TaskWPB-9784 [Android] accessibility strings – Conversation details

What's new in this PR?

Issues

After updating Accessibility strings deviceItem is un-accessible for UI tests.

Solutions

Add testTag to the DeviceItem

@borichellow borichellow self-assigned this Nov 6, 2024
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Nov 6, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Built wire-android-staging-compat-pr-3597.apk is available for download

@borichellow borichellow added this pull request to the merge queue Nov 7, 2024
Merged via the queue into release/candidate with commit ed80ab9 Nov 7, 2024
13 of 14 checks passed
@borichellow borichellow deleted the fix/test_tag_for_device_item branch November 7, 2024 10:48
github-actions bot pushed a commit that referenced this pull request Nov 7, 2024
@borichellow @github-actions
fix: TestTag for DeviceItem #WPB-9784 (#3597)
0ec3df1
@github-actions github-actions bot mentioned this pull request Nov 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamilmedina yamilmedina yamilmedina approved these changes

@ohassine ohassine ohassine approved these changes

@Garzas Garzas Awaiting requested review from Garzas

@saleniuk saleniuk Awaiting requested review from saleniuk

@damian-kaczmarek damian-kaczmarek Awaiting requested review from damian-kaczmarek

Assignees

@borichellow borichellow

Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@borichellow @yamilmedina @ohassine